Repository navigation
Discuss the merge of DAGNode, Node, BaseNode and Context and BaseContext #5556
Description
alxbilger
Issue body actions
No description provided.
Reactions are currently unavailable
Activity
Happy to see a revival of this topic and I agree having 4 layers of abstraction is over-engineering.
(for the record, BaseNode made sense a long time ago when there was a DAGNode and TreeNode)...... To me all that should be merged:
- probably first merge DAGNode -> Node
- then BaseNode -> Node (with an alias to keep BaseNode)
- then BaseContext in Context (with an alias to keep BaseContext)
Reacted by Alex BilgerAbout simplifying the Node code:
there is also:Additional cleaning related is the refactor of DAGSimulation and Simulation
So the merging of Node & DAGNode in #5566 is now passing unit tests. So it is ready for review and finalization.
What could could be the next doable step ?
- merge Context in BaseContext and make an alias from BaseContex to Context (DONE in [Sofa.Core] Merge BaseContext and Context #5608)
- remove the in-heritance on Node to Context
- remove DAGSimulation (DONE in [Sofa.Simulation.Graph] Remove DAGSimulation and DAGNode #5610)
- remove the singleton in Simulation
...
Now that #5566 has been merge, maybe we can try the next step.
