Skip to content

[Framwork] Fix 'unused' warnings (and some others) - #6310

Open
fredroy wants to merge 1 commit into
sofa-framework:masterfrom
fredroy:warning_unused_framework
Open

fredroy wants to merge 1 commit into
sofa-framework:masterfrom
fredroy:warning_unused_framework

Conversation

@fredroy

@fredroy fredroy commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

courtesy of Qwen next + opencode.
He also did the tests (where nobody gives a damn 😶‍🌫️)

  • DrawColoredMesh: SOFA_UNUSED() the parameters of the empty doDraw specializations for Edge/Triangle/Quad/Prism/Pyramid.
  • IdentityMatrix: SOFA_UNUSED() the identity operand in the operators that do not consume it.
  • MechanicalPropagateOnlyVelocityVisitor: SOFA_UNUSED(time).
  • Visitor_test: SOFA_UNUSED() the parameters of the override stubs.
  • TopologySubsetIndices_test: mark init/getTopologyType/getNbPoints as override (they override base-class virtuals).
  • Proximity_test: static_cast() the [[nodiscard]] call.
  • Triangle_test: drop two unused 'using Scalar = ...' aliases.

[with-all-tests]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code pr: AI-aided Label notifying the reviewers that part or all of the PR has been generated with the help of an AI pr: fast merge Minor change that can be merged without waiting for the 7 review days labels Sep 15, 2026
- DrawColoredMesh: SOFA_UNUSED() the parameters of the empty doDraw
  specializations for Edge/Triangle/Quad/Prism/Pyramid.
- IdentityMatrix: SOFA_UNUSED() the identity operand in the operators that do
  not consume it.
- MechanicalPropagateOnlyVelocityVisitor: SOFA_UNUSED(time).
- Visitor_test: SOFA_UNUSED() the parameters of the override stubs.
- TopologySubsetIndices_test: mark init/getTopologyType/getNbPoints as
  override (they override base-class virtuals).
- Proximity_test: static_cast<void>() the [[nodiscard]] call.
- Triangle_test: drop two unused 'using Scalar = ...' aliases.
@fredroy
fredroy force-pushed the warning_unused_framework branch from 709647a to 6d3bd01 Compare September 15, 2026 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: AI-aided Label notifying the reviewers that part or all of the PR has been generated with the help of an AI pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant