Repository navigation
[Mobile] Issue detail: sub-issues, links, development, watch - #25
Merged
Merged
Conversation
Closes #7. Sub-issue progress reads the issue's own child_count and completed_child_count rather than tallying the child list: the server excludes cancelled children from both, so re-deriving it here would quietly disagree. Verified against a live instance -- cancelling a child leaves the denominator rather than counting as outstanding work forever. Only three link types can be created. The inverses (blocked_by, duplicated_by) are derived server-side and appear on the other issue, so they are listed but not offered, with a line in the picker saying so. A blocking link is also what drives the board's blocked marker, so adding one re-reads the issue list. Development is read-only and hides itself when empty -- those rows arrive by webhook from the repository side, so there is nothing to create, and a permanently empty section is just noise on a phone. Watch reads the current state rather than assuming it, because the server auto-watches on assignment and commenting: the toggle reflects something that changes without being touched here. The link target picker filters the team's already-cached issue page on identifier as well as title, since "ENG-142" is what people actually type. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7.
Stacked on the issue-creation PR.
Sub-issue progress reads the issue's own
child_count/completed_child_countrather than tallying the child list: the server excludes cancelled children from both, so re-deriving it here would quietly disagree. Verified live — cancelling a child leaves the denominator rather than counting as outstanding work forever.Only three link types can be created. The inverses (
blocked_by,duplicated_by) are derived server-side and appear on the other issue, so they are listed but not offered, with a line in the picker saying so. A blocking link also drives the board's blocked marker, so adding one re-reads the issue list.Development is read-only and hides itself when empty — those rows arrive by webhook, so there is nothing to create, and a permanently empty section is noise on a phone.
Watch reads the current state rather than assuming it, because the server auto-watches on assignment and commenting.
Verification
5 integration tests, including that a link's inverse appears on the other issue and that removing it clears both sides.