Repository navigation
[Mobile] Notifications: inbox and push - #32
Merged
Merged
Conversation
Part of #10 -- the in-app half. Push is not built, and cannot be from here. The issue anticipated this: push "requires a backend addition for device token registration + push delivery". There is no /devices endpoint and nothing APNs- or FCM-shaped anywhere in the schema, so there is nowhere to send a token. The badge therefore polls once a minute and only while the app is in front -- a phone that polls in the background is a phone with a flat battery -- rather than pretending to be pushed. Recorded in the README rather than left to be discovered. Each of the four kinds gets its own sentence: "commented on" and "mentioned you in" are not the same event even though both are a comment. A notification is marked read on the way out rather than on arrival, because opening it is what says it was seen, and navigation still happens if that write fails -- getting to the issue matters more than the flag. Unread is carried by a marker rather than a row background, so the list does not change colour as things are read. Verified against a live instance with two accounts, which is the only way to show the acceptance criterion that your own actions notify nobody. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #10 — the in-app half. Push is not built, and cannot be from here.
The issue anticipated this: push "requires a backend addition for device token registration + push delivery". There is no
/devicesendpoint and nothing APNs- or FCM-shaped anywhere in the schema, so there is nowhere to send a token. Real push would also need a dev build and signing credentials, neither of which exists yet.So the badge polls once a minute and only while the app is in front — a phone that polls in the background is a phone with a flat battery — rather than pretending to be pushed. Recorded in the README rather than left to be discovered.
I'd suggest leaving #10 open after this merges, with the remaining scope being the backend addition plus the client side that depends on it.
Each of the four kinds gets its own sentence: "commented on" and "mentioned you in" are not the same event even though both are a comment. A notification is marked read on the way out rather than on arrival, and navigation still happens if that write fails.
Verification
5 integration tests with two accounts, which is the only way to show the acceptance criterion that your own actions notify nobody.