Tap e2e test#4318
Draft
j-piasecki wants to merge 4 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an Argent-driven “Basic Tap” end-to-end test flow and CI workflows to run it on Android and iOS, plus small UI/test hooks in the example app so the flow can reliably locate elements and assert gesture callback ordering.
Changes:
- Add Android and iOS GitHub Actions workflows to build the Expo example app and run the
simple-tap-testArgent flow. - Update the “Tap” example to expose a deterministic tap counter, log ordered gesture lifecycle events, and add a
testIDfor the tappable box. - Add missing
testIDs for console modal buttons and rename “Simple Gestures” entries to “Basic …” to match the test flow.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| apps/common-app/src/new_api/simple/tap/index.tsx | Adds tap counter UI, ordered logging, and testID for E2E automation. |
| apps/common-app/src/new_api/index.tsx | Renames “Simple Gestures” examples to “Basic …” for discoverability/E2E selection. |
| apps/common-app/src/console/ConsoleModal.tsx | Adds testIDs needed for console interactions in the E2E flow. |
| .github/workflows/ios-e2e.yml | New CI workflow to build iOS simulator app and run Argent tap flow. |
| .github/workflows/android-e2e.yml | New CI workflow to build Android app, boot emulator, and run Argent tap flow. |
| .argent/flows/simple-tap-test.yaml | Defines the Argent flow steps/assertions for the “Basic Tap” E2E test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
47
to
+57
| const tapGesture = useTapGesture({ | ||
| onBegin: () => { | ||
| log('onBegin'); | ||
| colorProgress.value = withTiming(1, { | ||
| duration: 100, | ||
| }); | ||
| }, | ||
| onActivate: () => { | ||
| log('onActivate'); | ||
| scheduleOnRN(setCount, count + 1); | ||
| }, |
j-piasecki
force-pushed
the
@jpiasecki/tap-e2e
branch
from
July 16, 2026 08:07
958acd2 to
085d4c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test plan