Return short reads from ByteFlow.runToInputStream - #364
Open
adamw wants to merge 3 commits into
Open
Conversation
Bulk read(byte[], off, len) blocked until the buffer was full or the stream ended, so consumers reading large buffers stalled on live sources. It now blocks only for the first byte and returns what is buffered. Closes #354
Rename the non-blocking helper, trim comments and javadoc, and restore the bulk-read assertions in handleEmptyChunksInStream so it fails on the old behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The InputStream returned by ByteFlow.runToInputStream filled the whole buffer on bulk reads, blocking for further chunks until the buffer was full or the stream ended. Consumers that read in large blocks (e.g. Jackson, 8 KB) stalled on live sources.
Bulk reads now block only until at least one byte is available, copy what is already buffered from the current chunk, and return the count. End of stream still returns -1.
Closes #354