rtc: armada38x: disable update interrupt feature#595
Conversation
Stop advertising update interrupts for the armada38x RTC driver Signed-off-by: fountzou <ioannis.fountzoulas@nokia.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@lizhijianrd @saiarcot895 Please help review. This is an alternate fix for the RTC issue |
paulmenzel
left a comment
paulmenzel
left a comment
There was a problem hiding this comment.
Thank you. Please send the patch upstream for review.
| @@ -0,0 +1,25 @@ | |||
| From 97dafb76ffc08cbac6bca2568e8d179d7f2f3632 Mon Sep 17 00:00:00 2001 | |||
| From: fountzou <ioannis.fountzoulas@nokia.com> | |||
There was a problem hiding this comment.
Please use your full name.
| From: fountzou <ioannis.fountzoulas@nokia.com> | ||
| Date: Wed, 1 Jul 2026 11:50:21 -0400 | ||
| Subject: [PATCH] Clear UIE bit from armada38x RTC driver | ||
|
|
There was a problem hiding this comment.
Please add a commit message suitable for Linux upstream. (What is the problem? How is it fixed and tested? Please also detail why the CPU hangs, and if it’s an hardware issue.)
There was a problem hiding this comment.
Thank you for your comment. Done
| else | ||
| clear_bit(RTC_FEATURE_ALARM, rtc->rtc_dev->features); | ||
|
|
||
| + clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, rtc->rtc_dev->features); |
There was a problem hiding this comment.
Comment has been added. Thanks.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
fountzou
force-pushed
the
disable_uie_in_armada_driver
branch
from
61df5d7 to
8433e6b
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Ioannis Fountzoulas <ioannis.fountzoulas@nokia.com>
fountzou
force-pushed
the
disable_uie_in_armada_driver
branch
from
8433e6b to
fbd598a
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Thank you for the improvement. Please send the patch upstream for review from the Linux maintainers.
There was a problem hiding this comment.
Thanks for the review and the suggestion. I've submitted the patch upstream: https://lkml.org/lkml/2026/7/4/606
4 participants
Stop advertising update interrupts for the armada38x RTC driver.
SONiC switched to chrony, which enables RTC update interrupts via the RTC_UIE_ON ioctl. On the armada38x RTC driver, big skew in time can lead to pinning the CPU and triggering the RCU stall and reboot.
We clear the RTC_FEATURE_UPDATE_INTERRUPT at probe time, so RTC_UIE_ON no longer takes the native periodic-timer path and instead routes to the UIE emulation path (dbd69ff).