Repository navigation
test: argument quoting, clipboard fallback, and landing page visual regression - #212
Merged
0xsamuel1 merged 1 commit intoOct 16, 2026
Conversation
…sual regression - testkit.test.ts: add quoting regression tests across coverage/limits/audit (unquoted when no spaces, quoted when spaces, default-path fallbacks) - clipboard.ts: extract copyToClipboard with an execCommand fallback for browsers without navigator.clipboard, used by App.tsx's copy button - clipboard.test.ts: cover the Clipboard API path, the no-Clipboard-API fallback, and the case where the fallback copy is rejected - App.test.tsx: browser-level tests that clicking Copy writes the currently-generated command to the clipboard, for the active tab, and that copying still succeeds with no Clipboard API present - playwright.config.ts, tests/visual/landing.spec.ts: add visual regression coverage for the landing page (hero, modules, command workbench per tab, full page), wired into CI as a separate job
|
@maja507 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testkit.test.ts: regression tests forbuildCommand's argument quoting acrosscoverage,limits, andaudit— unquoted when the path has no spaces, quoted when it does, and the unquoted default-path fallbacks.clipboard.ts: extracts the copy logic intocopyToClipboard, adding anexecCommand-based fallback for browsers/contexts wherenavigator.clipboardisn't available;App.tsx's copy button now uses it.clipboard.test.ts: covers the Clipboard API path, the no-Clipboard-API fallback, and the fallback-rejected case.App.test.tsx: browser-level (RTL/jsdom) tests that clicking Copy writes the command generated for the currently-active tab, and that copying still works with no Clipboard API present.playwright.config.ts+tests/visual/landing.spec.ts: adds visual regression coverage for the landing page (hero, modules, the command workbench per tab, full page), run as a separatevisual-regressionCI job.Setup note for #210: this introduces
@playwright/testas a new devDependency and atest:visual/test:visual:updatescript. Per this session's "no installs" constraint I did not runnpm installor generate screenshots, so there are no baseline images yet — thevisual-regressionCI job will fail until someone runsnpm run test:visual:updateonce (with the dev server building successfully) and commits the resultingtests/visual/__screenshots__/baselines.Closes #208,
Closes #209,
Closes #210,
Closes #211.