Repository navigation
feat: command builder accessibility, keyboard navigation, reset, and validation states - #213
Open
bade2brazy wants to merge 1 commit into
Open
bade2brazy wants to merge 1 commit into
bade2brazy wants to merge 1 commit into
Conversation
…set, and validation states - Add ARIA tablist/tab/tabpanel attributes, accessible labels, and live region (fixes soroban-testkit#203) - Add arrow key and Home/End keyboard navigation across workflow tabs with roving tabIndex (fixes soroban-testkit#204) - Add reset button to restore workflow defaults and announce reset (fixes soroban-testkit#205) - Add clipboard success and failure states with error recovery and live announcements (fixes soroban-testkit#206) - Add validation for required paths and Rust identifiers with alert states (fixes soroban-testkit#207) - Add comprehensive test suites for accessibility, keyboard navigation, reset, clipboard, and validation - Update README documentation with new capabilities
|
@bade2brazy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #203
Closes #204
Closes #205
Closes #206
Closes #207
This pull request enhances the Soroban Testkit command builder with WAI-ARIA accessibility compliance, keyboard workflow navigation, default reset capabilities, clipboard feedback, and input validation with error recovery.
Key Changes
role="tablist",aria-label="CLI commands",role="tab",aria-selected,aria-controls,id).role="tabpanel",id,aria-labelledby).htmlForandid.role="status"andaria-live="polite".tabIndex(0for active tab,-1for inactive tabs).ArrowRight/ArrowLeft,ArrowDown/ArrowUp) across workflow tabs with automatic cycling.Home(first tab) andEnd(last tab).Resetaction to restore customized options back to canonical workflow defaults (DEFAULT_OPTIONS).Copiedlabel, polite live region announcement).Failedlabel, error styling, failure announcement).Copyafter timeout to allow retrying.fnandrampvalidated as valid Rust identifiers).role="alert"messages linked to inputs viaaria-invalidandaria-describedby.src/testkit.test.tsfor input validation rules.src/App.test.tsxcovering accessibility assertions, keyboard navigation, reset behavior, clipboard success/error handling, and invalid input states.README.mddocumenting new CLI workbench capabilities.