Repository navigation
feat layout - #218
Merged
Merged
feat layout#218
Conversation
|
@Ghoost-404 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #176
Closes #177
Closes #178
Closes #179
Changes
1. Multi-line & Responsive Command Formatting (
src/testkit.ts)formatCommandLine(options, multiline): Added command string formatting utility that outputs standard POSIX shell line continuations (\) with clean two-space indentation whenmultiline = true, while maintaining identical single-line output whenmultiline = false.coverage,limits, andaudit.2. Versioned CLI Compatibility Matrix (
src/testkit.ts)cliCompatibility: Added structured compatibility mapping tracking:v0.2.0(Current): Soroban SDK27.0.x, Stellar CLI>= 22.0.0, Targetwasm32v1-none(Rust>= 1.84).v0.1.0(Supported): Soroban SDK22.x - 26.x, Stellar CLI>= 21.0.0, Targetwasm32-unknown-unknown / wasm32v1-none.v0.3.0(Upcoming): Soroban SDK28.0.x+, Stellar CLI>= 23.0.0, Targetwasm32v1-none(Rust 2024 edition).3. Local Project File Integration Documentation (
src/testkit.ts)localFileGuides: Documented how each generated CLI workflow interacts with the developer's local project files:coverage: ReadsCargo.toml,Cargo.lock,src/**/*.rs, andtests/**/*.rs; writes local coverage artifacts totarget/llvm-cov/htmlorlcov.info.limits: Reads pre-compiled WebAssembly bytecode (target/wasm32v1-none/release/contract.wasm); outputs instruction ceilings and RAM byte limits to stdout without file mutation.audit: Parses local Rust AST for authorization checks, unchecked arithmetic, and TTL risks; outputs diagnostics to stdout without file mutation.4. Test Suite & Visual Regression Hardening
src/testkit.test.ts: Added 13 unit tests verifying multi-line formatting with backslash continuations, quoting rules, compatibility table invariants, and file guide coverage.src/clipboard.test.ts: Removed unusedbeforeEachimport (fixes TypeScript TS6133 lint error).src/test/setup.ts: Registered Testing Library'scleanup()inafterEach()to avoid DOM bleed between tests.vite.config.ts: Excludedtests/visual/**from Vitest runs to keep unit and visual test suites isolated.tests/visual/__screenshots__/: Generated Playwright baseline screenshots forhero,modules,commands(per tab), andfull-page.Validation
npm testpasses with 22/22 tests passing across all suites.npm run build(tsc -b && vite build) compiles with zero errors.npm run lintpasses cleanly.npm run test:visualexecuted and matched baseline snapshots.