Bug Fix: keep local changes commit controls visible on short windows - #2690
Merged
Merged
Conversation
changes commit controls visible
love-linger
force-pushed
the
develop
branch
from
September 10, 2026 04:13
00874a1 to
35cfc45
Compare
Collaborator
Please remove all other changes except the 2nd one. The main principle for this page is we should leave more space to the diff viewer rather than the commit message editor. And if they want a larger commit message editor, they can use the splitter to resize it. |
Contributor
Author
|
it's done I've tested again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
The commit editor and commit action buttons disappear from the
Local Changespage when the application window is resized to a shorter height.This happens because the diff panel has a fixed minimum height of 400
pixels, while the commit message editor also reserves a fixed height of 128
pixels. When the available vertical space becomes smaller than the combined
layout requirements, the commit editor and action row are pushed outside the
visible area.
Solution
Make the right side of the
Local Changespage responsive to the availableheight:
3*row for the diff panel and a1*row for the commit messageeditor.
together.
This keeps the commit controls accessible when the application window is
vertically constrained while preserving the existing layout behavior at
larger sizes.
Validation
video with bug
bug.mp4
video without bug
without-bug.mp4