Skip to content

Do not assume process.report.getReport() returns a report on NPM - #920

Merged
jviotti merged 1 commit into
mainfrom
fix-npm
Oct 13, 2026
Merged

jviotti merged 1 commit into
mainfrom
fix-npm

Conversation

@jviotti

@jviotti jviotti commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

Fixes: #896
Signed-off-by: Juan Cruz Viotti jv@jviotti.com

View guided diff

Fixes: #896
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

View guided diff | Re-trigger cubic

@augmentcode

augmentcode Bot commented Oct 13, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Adds a null-safe guard before accessing the diagnostic report header in the NPM wrapper's musl detection.
Prevents module-load crashes when environments such as VS Code's extension host return no report, using the existing non-musl fallback.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@jviotti
jviotti merged commit b3b6fd2 into main Oct 13, 2026
16 checks passed
@jviotti
jviotti deleted the fix-npm branch October 13, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

npm: isMusl() crashes when process.report.getReport() returns undefined (breaks Sourcemeta Studio in VS Code on Linux)

1 participant