Skip to content

Fix: Disable attachment relationships in batch edit#8317

Merged
rijulpoudel merged 1 commit into
v7_12_0_7_basefrom
issue-8314
Jul 16, 2026
Merged

Fix: Disable attachment relationships in batch edit#8317
rijulpoudel merged 1 commit into
v7_12_0_7_basefrom
issue-8314

Conversation

@CarolineDenis

Copy link
Copy Markdown
Contributor

Fixes #8314

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add pr to documentation list
  • Add automated tests
  • Add a reverse migration if a migration is present in the PR
  • Add migration function to
    def fix_schema_config(stdout: WriteToStdOut | None = None):

Testing instructions

  • Create a query with an attachment relationship. (I.e: collection object base table >> collection object attachment >> attachment >> title)
  • Save your query
  • Click batch edit
  • Verify attachment "title" column is disabled

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e26b0ea3-7cc0-44ed-9e1d-a7345955c79b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-8314

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@CarolineDenis CarolineDenis requested review from a team and melton-jason July 16, 2026 09:30
@CarolineDenis CarolineDenis linked an issue Jul 16, 2026 that may be closed by this pull request

@emenslin emenslin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify attachment "title" column is disabled

Looks good, all attachment columns are read-only in Batch Edit

@emenslin emenslin requested a review from a team July 16, 2026 13:08
@rijulpoudel rijulpoudel self-requested a review July 16, 2026 15:12

@rijulpoudel rijulpoudel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • Create a query with an attachment relationship. (I.e: collection object base table
  • collection object attachment >> attachment >> title)
  • Save your query
  • Click batch edit
  • Verify attachment "title" column is disabled

Successful test! The "title" column is disabled in Batch Edit.

@g1rly-c0d3r g1rly-c0d3r left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify attachment "title" column is disabled

Looks good, I can edit base table columns but not attachments.

@rijulpoudel rijulpoudel merged commit 27cb105 into v7_12_0_7_base Jul 16, 2026
14 of 15 checks passed
@rijulpoudel rijulpoudel deleted the issue-8314 branch July 16, 2026 16:20
@github-project-automation github-project-automation Bot moved this from 📋Back Log to ✅Done in General Tester Board Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅Done

Development

Successfully merging this pull request may close these issues.

Disable attachment relationships in Batch Edit

4 participants