Remove logger name field from all records - #206
Merged
Merged
Conversation
Every record was named pr-preview, which pino-pretty printed as "(pr-preview)" after the level on every line. The process is the whole app, so the name says nothing the reader doesn't already know, in the pretty output or in the JSON. Remove it from the records rather than hiding it in one format. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ESNyrfgCbty7Vui7uXRuKr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the hardcoded
pr-previewname field from all logger records, simplifying the logging output since the process itself is the whole app and doesn't need to identify itself in every log line.Changes
NAME = "pr-preview"constant and stopped setting thenameoption when creating the pino loggernamefield in log records(pr-preview)from the expected log line formatDetails
The logger previously added a
name: "pr-preview"field to every record, which was redundant since this application is the entire process. By removing this field, log output becomes cleaner and more concise, especially in pretty-printed format where the level and PR/action information are already sufficient context.https://claude.ai/code/session_01ESNyrfgCbty7Vui7uXRuKr