Bump Wasmtime to v48.0.0 prerelease - #3653
Conversation
Signed-off-by: spinframeworkbot <202838904+spinframeworkbot@users.noreply.github.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
|
I bumped it to 1.95 and fixed up the low-hanging fruit around filesystem permissions, but there's a big pile of errors around changes to the sockets API that I don't know how to start on. |
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
|
I updated the SocketAddrUse stuff based on bytecodealliance/wasmtime#13934, but it needs someone to check it because I am somewhat guessing! A lot of the upstream sockets stuff has changed from sync to async or from async to sync. For some of it I was able to propagate the change without obvious problems, but there are some cases (I think all implementing RCs) where we are constrained by a sync trait but the underlying API is now async, and my usual kludges for bridging over that feel ill-advised. So @alexcrichton or @dicej I think I am going to need to punt those to you - sorry. |
|
Thanks for getting this going, @itowlson! I'm addressing the remaining issues and will push an update. |
2082111 to
7b728be
Compare
| ctx: PrepareContext<T, Self>, | ||
| ) -> anyhow::Result<InstanceBuilder> { | ||
| let mut wasi_ctx = WasiCtxBuilder::new(); | ||
| wasi_ctx.allow_tcp(true).allow_udp(true); |
There was a problem hiding this comment.
One thing on this -- this probably only wants to happen if sockets/addresses are otherwise allowed for this component. Otherwise this is technically a vector by which guests can create fds on the host and may cause minor issues. Would it be possible to make these conditional based on other settings? Or are guests expected to always be able to create a socket and outgoing connections?
There was a problem hiding this comment.
Should be possible to extend OutboundAllowedHosts with a "is this protocol ever allowed" method.
6 participants
Bumps Wasmtime to v48.0.0 prerelease