Accept boolish values for env-settable bool flags - #3668
Open
ChihweiLHBird wants to merge 1 commit into
Open
Conversation
Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supporting broader boolish values, like
1,0,yesby adding BoolishValueParser.Note that some input arguments are impacted by a conflicting issue caused by a clap issue clap-rs/clap#5591 which is a pre-existing issue before this PR. An example is even if
DISABLE_WASMTIME_CACHEis set to false, it still conflicts toWASMTIME_CACHE_FILE. Clap check whether it's set rather than whether it's set to true.