Repository navigation
fix(windows): preserve other applications' startup entries - #145
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83
The Windows installer now creates the shared
HKCU\…\Runkey only when it is absent. It continues to overwrite only Token Meter’s own startup value on reinstall.The Windows install workflow now seeds an unrelated startup entry and verifies its data and registry type survive install, reinstall, update, and uninstall.
Validation:
python3 scripts/run-tests: 2,601 tests; 21 skippedpython3 -m unittest tests.contracts.test_windows_packaging -v: 38 tests; 3 Windows-native skips on macOSgit diff --checkThe added Windows lifecycle checks will run on the pull request.