Repository navigation
Conversation
Member
|
@ddobrin Could you review the changes? Thanks! |
Author
|
@ddobrin tested on my project with gemini-2.5-flash-tts and gemini-2.5-pro-tts, with different voices and turns |
Member
|
@OreOreDa Thanks for the PR! Could you rebase and squash all the changes into a single commit? |
Author
Done |
| : toWav(pcmAudio); | ||
|
|
||
| final TextToSpeechResponseMetadata metadata = new TextToSpeechResponseMetadata(); | ||
| metadata.setUsage(new DefaultUsage(text.length(), audioContent.length)); |
Member
There was a problem hiding this comment.
This needs to be changed to use usage metadata.
| @ConfigurationProperties(GoogleGenAiTextToSpeechConnectionProperties.CONFIG_PREFIX) | ||
| public class GoogleGenAiTextToSpeechConnectionProperties { | ||
|
|
||
| public static final String CONFIG_PREFIX = "spring.ai.google.genai.tts"; |
Member
There was a problem hiding this comment.
For consistency, we need to use spring.ai.google.genai as the prefix.
ilayaperumalg
approved these changes
Oct 13, 2026
ilayaperumalg
left a comment
ilayaperumalg
left a comment
Member
There was a problem hiding this comment.
@OreOreDa Thanks for the PR! Will address the review comments when merging.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes GH-6879
Signed-off-by: Olivier Le Quellec olivier.le-quellec@live.fr
Thanks !