Channel artifacts carry reviewed verification status — nine drivers stop reading UNTESTED - #76
Merged
Merged
Conversation
The builder stamped verification_status: experimental into every published artifact -- a sound default when 80 unverified community ports were imported wholesale, and wrong the moment a driver earned a hardware-validated production status the review accepted: the FTW UI renders the artifact's metadata, so no amount of evidence in the DRIVER block could ever change the operator-facing UNTESTED badge. The channel now carries the DRIVER block's verification_status (and its notes) when the declared status is production or beta -- a checkable claim a reviewer gated -- and keeps the conservative default for absent, experimental, or out-of-vocabulary values, which also keeps every already-published untested driver's bytes unchanged. A published version names a set of bytes, so the nine drivers whose artifact metadata changes get patch bumps: ctek 0.3.2, ctek_v2 0.3.2, easee_cloud 1.1.1, ferroamp 2.1.1, foxess_h3_smart 0.9.2, nibe_local 1.1.2, sungrow 1.5.8, tesla_vehicle 0.2.1, zap 2.0.2. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Leitet <johan@sourceful-labs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FTW UI's badge ("untested" / "in testing" / "verified on hardware") renders the artifact's metadata, and the channel builder hardcoded
verification_status: experimentalinto every artifact it published — so no amount of hardware evidence in a DRIVER block could ever change what operators see. Found while trying to makefoxess_h3_smart's badge reflect its multi-day hardware validation (#71).The rule this PR adds: the channel repeats the DRIVER block's verification claim only when it is one the review actually gated — a declared
productionorbetais a checkable statement a reviewer accepted, so the artifact carries it (with the driver's ownverification_noteswhen present). Absent,experimental, or out-of-vocabulary values keep the conservative default, which also keeps every already-published untested driver's bytes unchanged.Blast radius, priced in: artifact metadata is part of the signed bytes, so the nine drivers whose artifacts change get patch bumps (
ctek,ctek_v2,easee_cloud,ferroamp,foxess_h3_smart,nibe_local,sungrow,tesla_vehicle,zap). The other 71 drivers publish byte-identical artifacts — the "signed channel accepts this tree" check verifies exactly that.🤖 Generated with Claude Code