Point Browse drivers at the published device catalog - #7
Conversation
The Build section linked to github.com/srcfl/ftw/tree/master/drivers, a directory that holds no driver source — the Lua files are gitignored there and fetched at build time, so the only thing on that page is BUNDLED_SOURCE.json. A visitor following "Browse drivers" found no drivers to browse. srcfl/device-drivers now publishes a searchable catalog of all 80 drivers, generated from its manifests and driver sources. That link replaces the dead one, and the catalog also gets a Devices item in the primary nav and a footer entry under Project. Signed-off-by: Hugo Karlsson <48095810+HuggeK@users.noreply.github.com> Co-authored-by: HuggeK <48095810+HuggeK@users.noreply.github.com>
|
Once srcfl/device-drivers#51 goes live this is safe. |
miravoss26
left a comment
There was a problem hiding this comment.
Repoints the landing page's driver links at the published catalog: a new Devices nav item, the "Browse drivers" action, and a footer link, all to https://srcfl.github.io/device-drivers/.
- One blocker, and it's not in the diff: GitHub currently has this branch as
CONFLICTINGagainst base. It'll need a rebase before it can merge. - Every new or changed href points at the org's own Pages domain over https. No scripts, no other surface touched, nothing security-relevant.
Content reads fine and matches the catalog framing in ftw#720/#727. Safe to merge from my read once the conflict is cleared.
miravoss26
left a comment
There was a problem hiding this comment.
Steward review (automated sweep). Three link/nav edits in index.html: "Browse drivers" now points at the published catalog, a new Devices nav item, and a Device catalog footer link. Reads clean, no security surface (static links).
Two things before this lands:
- The branch is CONFLICTING against master, needs a rebase.
- Your own note says to hold until srcfl/device-drivers#51 merges and Pages publishes, otherwise
https://srcfl.github.io/device-drivers/404s. Worth confirming that's live first.
Content is good. Not merging from my side: ftw-web isn't on my merge allowlist, and this still needs the rebase + the catalog live.
Resolves the conflict this branch had against base. Both sides edited the same two links in the Build section's inline-actions. srcfl#6 landed after this branch was cut and repointed both links at srcfl/device-drivers: "Write a driver" at docs/WRITING-A-DRIVER.md and "Browse drivers" at drivers/lua. That first fix is kept as-is -- this branch never meant to touch it, and the ftw URL on this side is only an artifact of the older base. "Browse drivers" takes this branch's version: the published catalog at srcfl.github.io/device-drivers/. That is not a regression of srcfl#6's fix. The catalog is generated from the same repository and every one of its 80 entries carries a source_url into drivers/lua/*.lua, so it indexes the directory srcfl#6 linked and adds search by manufacturer and model plus filters for type, protocol, tier and control. Contributors keep the path to source; visitors get a page that answers what FTW supports. Co-authored-by: HuggeK <48095810+HuggeK@users.noreply.github.com>
|
Both blockers from review are cleared. Conflict. #6 landed after this branch was cut and edited the same two links in the Build section, which is where the Catalog live. srcfl/device-drivers#51 is merged and Pages has published — One thing worth flagging, since it changes the case for this PR rather than just restating it: the original justification no longer holds. This branch argued that It still stands on its own: the catalog is generated from that same repository and every one of its 80 entries carries a Also verified all 20 external links on the page return 200, |
miravoss26
left a comment
There was a problem hiding this comment.
Small, clean one-file change. It swaps the Browse drivers link (which pointed at ftw/tree/master/drivers, where the Lua source is gitignored) for the published catalog at srcfl.github.io/device-drivers, and adds a matching Devices nav item plus a footer Device catalog link.
- All three targets are the same first-party GitHub Pages URL. Consistent, and the copy change reads well.
- No script, no secrets, no new third-party origin. Nothing on the security screen.
Safe to merge from my read. ftw-web has no CI here, so a quick local open to eyeball nav spacing is the only thing I'd do first, nothing blocking.
srcfl/device-driverspublishes a catalog of all 80 drivers at https://srcfl.github.io/device-drivers/, generated from its manifests and driver sources on every push. This points the site at it.Three changes, all in
index.html:Browse drivers→Browse the device catalog, pointing at the catalogDevicesitem betweenBuildandCommunityDevice cataloglinkThe catalog is searchable by manufacturer or model number — typing
SH10RTfinds the Sungrow driver — and filterable by device type, protocol, tier and control. It reports hardware evidence honestly: 5 drivers state they have been confirmed against physical hardware, 28 state they have not.Why the catalog rather than the
drivers/luadirectory #6 now linksThis branch was opened when
Browse driversstill pointed atsrcfl/ftw/tree/master/drivers, which held no driver source — the Lua files are gitignored insrcfl/ftwand fetched at build time, so the only thing on that page wasBUNDLED_SOURCE.json. That original argument is spent: #6 landed first and repointed the link atsrcfl/device-drivers/tree/main/drivers/lua, which does hold the source.The catalog is still the better destination, and it does not cost contributors the path to source. It is generated from that same repository, and all 80 entries carry a
source_urlintodrivers/lua/*.lua— so it indexes the exact directory #6 linked and adds search by manufacturer and model, plus filters for type, protocol, tier and control. A driver author still reaches the Lua; a visitor asking what FTW supports gets an answer instead of a file listing.Write a driverkeeps the URL #6 gave it — this branch never meant to change it.Conflict with #6, and how it was resolved
#6 landed after this branch was cut and edited the same two links in the Build section's
inline-actions, so GitHub marked the branchCONFLICTING. Resolved by merging base in, taking #6'sWrite a driverURL and this branch's catalog link forBrowse drivers, as described above. The net diff against base is now exactly the three rows in the table.Checked
https://srcfl.github.io/device-drivers/returns 200, serving 80 drivers. feat: publish the catalog as a page built from the repository device-drivers#51 is merged, so the hold note on the earlier revision of this description no longer applies.index.htmlparses with no unclosed or mismatched tags, and every internal anchor (#architecture,#extend,#community,#start,#content,#top) has a matching target.sourceful.css. The nav readsARCHITECTURE · BUILD · DEVICES · COMMUNITY · DOCS · GITHUB ↗and still fits one line at 1440 px. No CSS change needed.🤖 Generated with Claude Code