fix(mpc): keep the newest replan - #889
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lastReasonunder the service lock and interpret each active slot with the mode that produced its plan.Root cause
Replans can run at the same time. A slow older solve could finish after a newer mode change or reactive trigger and replace the newer plan. The trigger reason could also drift from the plan, and some
lastReasonwrites were outside the mutex.The regression test blocks the first self-consumption solve, completes a newer arbitrage solve, then releases the old solve. It checks the active plan, mode, reason, generation, diagnosis and persisted diagnostic.
Tests on current master
f9297c0go test -race -count=1 ./internal/mpcgo test -race -count=1 ./internal/api ./cmd/ftwmake verify-allScope
This prevents stale publication. #893 now bounds the queue and active solver budget. Cancellation of superseded Core replans remains a small follow-up: an older solve may still consume work until its context or solver deadline ends, but it cannot publish over this request.
Refs #885