Skip to content

[M11] Design system, page frame, hero stage and footer (M11.3) - #92

Merged
ssoufii merged 1 commit into
mainfrom
auto/m11.3-design-system-frame-hero-footer
Nov 17, 2026
Merged

ssoufii merged 1 commit into
mainfrom
auto/m11.3-design-system-frame-hero-footer

Conversation

@ssoufii

@ssoufii ssoufii commented Nov 17, 2026

Copy link
Copy Markdown
Owner

Builds the design system and the page frame from docs/FRONTEND_DESIGN.md: the token file, the navigation, the hero with its shaped stage, and the block-built footer wordmark. The live console from M11.2 keeps every control and every test id it had, moved onto the stage and given the fragment's conventions, so nothing the engine already drove was lost.

What changed

  • web/src/styles/tokens.css is the only stylesheet with a literal colour, font family or type size: the palette (section 3), the five type steps plus the 15px chrome size that sections 5 and 6 both fix, the tower block sizes, the frame margins and the motion curves and durations (section 8). base.css and page.css reference them by name.
  • SiteNav, Hero, Console, TowerLoader, Wordmark and SiteFooter under web/src/components/. The stage's three-step notch is a clip-path polygon driven by --block-lg (72px, 40px below 1100). The footer wordmark's letter heights are a real skip list's levels, drawn with the engine's own SkipList at the default level probability; the exact snippet that produced them is in Wordmark.tsx.
  • web/tests/house-rules.spec.ts plus web/tests/support/house-rules.ts: every rule in section 7, at 1440, 768 and 390 wide, with a full-page screenshot per width written to web/test-results/screenshots/, a real tab walk for keyboard reachability, Playwright's own accessible-name computation for naming, a run with the font provider blocked, and a source scan that fails on a raw colour or type size outside the token file.
  • playwright.config.ts gains a second project, chromium-reduced-motion, which runs the whole suite under reducedMotion: 'reduce'.
  • index.html loads Pilcrow Rounded from Fontshare with preconnects, without blocking the first paint, so the page renders the same when the provider is unreachable.

Acceptance criteria

  • The palette, type steps and motion tokens of sections 3, 4 and 8 exist as CSS custom properties, and components reference tokens only. Checked by a test that reads the stylesheets off disk, not the page, so a literal that happens to equal a token still fails.
  • The navigation, the hero (h1, supporting sentence, one button, the maroon stage with the three-step notch, the console area with the boot status and the tower loader) and the footer (block-built wordmark and links) are built as section 6 describes, at desktop and phone widths.
  • web/tests/house-rules.spec.ts implements every check in section 7 at 1440, 768 and 390, passes, and passes with reducedMotion: 'reduce'.
  • The spec saves a full-page screenshot per width to web/test-results/screenshots/. The screenshots were opened and checked against the spec (see below).
  • With font requests blocked the page falls back cleanly and still passes the house rules.

What ran, and what passed

Everything ran locally, in this sandbox, and passed:

  • pytest: 1244 passed. ruff check src tests and ruff format --check src tests: clean. No Python changed in this story; this is the pre-existing suite still green.
  • In web/: npm ci, npm run lint, npm run typecheck, npm run build: clean.
  • npx playwright test: 26 passed, both projects. Playwright ran locally (the sandbox has a matching Chromium), not only in CI. That is 6 engine specs and 7 house-rules specs per project.

The house-rules audit was negative-tested before being trusted: a temporary stylesheet with a gradient, a shadow, a monospace face, 1px borders, an 8px radius, a tracked uppercase label, a backdrop-filter, a 12px paragraph and a low-contrast colour made all nine rules fire with the offending selector named, and the token scan caught the hex colour and the literal font size. The patch was reverted; it is not in this branch.

Screenshots at 1440, 768 and 390 were opened and checked: the headline holds two lines at every width, the outer margins match on both sides and across the three bands, the notch reads as three steps, the console is fully visible and uncropped, the footer wordmark shows the varied block heights with the two tallest letters in maroon, and nothing failed to render. The web font loaded in these runs, and the blocked-font test proves the rules also hold on the ui-rounded fallback.

Decisions taken without asking

Three readings of section 6 were resolved in favour of section 7's house rules, which are the checked contract:

  1. The hero copy spans eight columns, not six. At 1440 six columns is 668px and "a storage engine" sets about 738px at --step-hero, so six columns would push the headline to a third line. The headline's natural width still leaves it sitting left of the stage.
  2. The console is never cropped. Section 6 lets the stage's bottom edge cut it, and the right edge cut it on a phone. A clipped region does not scroll, so a control inside the crop would be focusable and invisible at the same time, which fails house rule 11. The stage itself still bleeds off the right and bottom edges of the hero; the console is fluid up to 620px instead.
  3. On the narrow layout the console sits under the notch, not beside it, as section 6's phone note describes, because beside it there is not enough width left for the fragment.

Two smaller ones: --step-hero is redefined to 10vw under 600px rather than a sixth size being added for the phone headline, and the three in-page navigation links point at section ids that later M11 stories add, so the navigation does not have to be rebuilt once per story.

Scope held to this story: no shutter, no section entrances, no tower or flush moves (all M11.9). The motion that is here is the boot loader, press feedback on the one button shape, hover behind @media (hover: hover) and (pointer: fine), and the reduced-motion fallbacks, because a control with no press state is not a motion layer, it is an unfinished button.

Closes #81


Generated by Claude Code

Story M11.3. The palette, type scale and motion tokens of
docs/FRONTEND_DESIGN.md become CSS custom properties in one token file,
and every other stylesheet references them by name. On top of that sit
the navigation, the hero (headline, one sentence, one button, the maroon
stage with the three-step notch, and the live console with its boot
status and tower loader) and the footer wordmark built from blocks whose
heights are a real skip list's levels.

web/tests/house-rules.spec.ts implements every check in section 7 at
1440, 768 and 390 wide, saves a full-page screenshot per width, walks the
tab order, and runs again with the font provider blocked. A second
Playwright project runs the whole suite under prefers-reduced-motion.

Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWNkuNh5Bysnfo2KrxL9Sp

ssoufii commented Nov 17, 2026

Copy link
Copy Markdown
Owner Author

CI note, for the record.

On the first run, test (macos-latest, 3.11) was cancelled when the job hit its 20 minute timeout partway through pytest. That failure is not this PR's: the diff changes no Python at all (it is web/, two docs files and the roadmap tick), the same pytest passed on macOS 3.12 and 3.13 and on all three Ubuntu versions in the same run, and it passes locally in about 40 seconds (1244 tests). It is the hung macOS runner this repository has seen before. The failed job was re-run once, as the pipeline allows, and it passed. No test was skipped, disabled or weakened, and nothing was pushed to kick CI.

ci-ok is now green on 41063fa, with lint, the full pytest matrix and the web job all passing.

One limitation worth stating rather than glossing over: the web-test-results artifact could not be downloaded in the environment this ran in, because the Azure blob host the artifact redirects to is refused by the sandbox's egress policy. The screenshots at 1440, 768 and 390 were therefore opened and checked from a local run of the same production build (vite preview of npm run build) with the same pinned @playwright/test and Chromium revision that CI uses, rather than from the CI artifact itself. The CI web job ran the identical spec and passed, including the screenshot step.


Generated by Claude Code

@ssoufii
ssoufii merged commit 88255d9 into main Nov 17, 2026
16 of 18 checks passed
@ssoufii
ssoufii deleted the auto/m11.3-design-system-frame-hero-footer branch November 17, 2026 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[M11] Design system, page frame, hero stage and footer (M11.3)

2 participants