add systemd-resolved configuration feature - #51
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the systemd-resolved configuration by introducing a block that conditionally enables the service, creates a configuration directory, deploys a DNS configuration template, and restarts the service. Feedback on these changes includes ensuring idempotency by conditionally restarting systemd-resolved only when the template configuration changes (and using the FQCN for the template module), as well as guarding the resolv_nameservers variable in the template with an is defined check to prevent execution failures when the variable is not provided.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Depends-On: stackhpc/ansible-collection-linux#51 Change-Id: Ie3c0d8f1b326705b84ac49f8bc94da8f07827f8c Signed-off-by: Rafal Lewandowski <rafal@stackhpc.com>
* Update kayobe from branch 'master'
to 697b9920bf264523b85941f1edeb1b6239b77032
- Merge "Enable systemd-resolved configuration for Debian based distros"
- Enable systemd-resolved configuration for Debian based distros
Depends-On: stackhpc/ansible-collection-linux#51
Change-Id: Ie3c0d8f1b326705b84ac49f8bc94da8f07827f8c
Signed-off-by: Rafal Lewandowski <rafal@stackhpc.com>
3 participants
No description provided.