chore: update dependencies and fix lint#210
Open
ondbeh wants to merge 3 commits into
Open
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
There was a problem hiding this comment.
Pull request overview
This PR updates Go/module dependencies and the linting/tooling setup, with small test refactors to satisfy lint rules and a rework of the Semgrep GitHub Actions workflow to run Semgrep directly and upload SARIF.
Changes:
- Bump golangci-lint version and adjust golangci-lint configuration (including switching to
gomodguard_v2). - Update Go module dependencies (
go.mod/go.sum) and refactor test literals into shared constants to address linting. - Replace the Semgrep GitHub Action with a container-based
semgrep scaninvocation that outputs SARIF.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| Makefile | Updates golangci-lint version and installation method/URL used by make lint. |
| internal/resolver/resolver_test.go | Introduces a testID constant to remove repeated string literals in mocks. |
| internal/repository/server_test.go | Replaces hardcoded RRSet names with testURL constant. |
| internal/repository/rrset_repositry_test.go | Introduces testURL constant and replaces repeated RRSet name literals. |
| go.mod | Bumps Kubernetes and other indirect dependencies. |
| go.sum | Updates dependency checksums in line with go.mod updates. |
| .golangci.yaml | Updates Go version for linting and switches linter config to gomodguard_v2. |
| .github/workflows/semgrep.yaml | Runs Semgrep via container + CLI and uploads SARIF via upload-sarif. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.