Skip to content

chore: update dependencies and fix lint#210

Open
ondbeh wants to merge 3 commits into
mainfrom
feature/patchday
Open

chore: update dependencies and fix lint#210
ondbeh wants to merge 3 commits into
mainfrom
feature/patchday

Conversation

@ondbeh

@ondbeh ondbeh commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@ondbeh ondbeh requested a review from a team July 2, 2026 07:02
@ondbeh ondbeh changed the title update dependencies and fix lint chore: update dependencies and fix lint Jul 2, 2026
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Go/module dependencies and the linting/tooling setup, with small test refactors to satisfy lint rules and a rework of the Semgrep GitHub Actions workflow to run Semgrep directly and upload SARIF.

Changes:

  • Bump golangci-lint version and adjust golangci-lint configuration (including switching to gomodguard_v2).
  • Update Go module dependencies (go.mod/go.sum) and refactor test literals into shared constants to address linting.
  • Replace the Semgrep GitHub Action with a container-based semgrep scan invocation that outputs SARIF.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
Makefile Updates golangci-lint version and installation method/URL used by make lint.
internal/resolver/resolver_test.go Introduces a testID constant to remove repeated string literals in mocks.
internal/repository/server_test.go Replaces hardcoded RRSet names with testURL constant.
internal/repository/rrset_repositry_test.go Introduces testURL constant and replaces repeated RRSet name literals.
go.mod Bumps Kubernetes and other indirect dependencies.
go.sum Updates dependency checksums in line with go.mod updates.
.golangci.yaml Updates Go version for linting and switches linter config to gomodguard_v2.
.github/workflows/semgrep.yaml Runs Semgrep via container + CLI and uploads SARIF via upload-sarif.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Makefile
Comment thread .github/workflows/semgrep.yaml Outdated
Comment thread .github/workflows/semgrep.yaml
Comment thread internal/repository/server_test.go
Comment thread internal/repository/server_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants