Repository navigation
Harden release docs owner resolution - #1312
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the release-docs ownership-resolution changes.
No open issues 🎉
What changed in this PR
Hardens release-docs ownership resolution so duplicate initiator metadata and mixed-case bot names fall back to the existing owner sources.
Changes:
- Requires exactly one
Release-Triggered-Byline before extracting the initiator. - Makes bot detection case-insensitive while preserving human login spelling.
- Adds regression tests for empty duplicate trailers, mixed-case bots, and human login casing.
| File | Description |
|---|---|
scripts/upstream-release/workflow.test.mjs |
Adds ownership-resolution regression tests. |
.github/workflows/upstream-release-docs.yml |
Counts initiator trailers before extraction and makes bot filtering case-insensitive. |
Review effort: Balanced
danbarr
enabled auto-merge (squash)
November 4, 2026 20:33
rdimitrov
approved these changes
Nov 4, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Release-docs owner resolution can accept a valid initiator followed by an empty duplicate trailer because shell command substitution removes the trailing newline. Count matching
Release-Triggered-Bylines before extracting the value and require exactly one, so duplicate metadata falls back to the existing owner sources.Make the shared bot filter case-insensitive to match GitHub login semantics. This excludes mixed-case bot names from initiator and fallback ownership while preserving human login spelling.
Validation: all 28 release-docs helper tests pass, including regressions for empty and whitespace-only duplicates, mixed-case bot initiators and fallback owners, and human login casing. Focused Prettier, ESLint,
git diff --check, and the production site build pass.Type of change
Related issues/PRs
Follow-up to #1311, addressing both Copilot review findings.