Repository navigation
Fix Enterprise release reference inputs - #1315
Merged
Merged
Conversation
Resolve Helm chart paths and description overrides from the source release version. Support the gateway layout in v0.26.0 while retaining the chart mapping for older releases. Report all missing Helm inputs before generating reference pages.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The private SEP sources and companion PR #6235 returned 404, leaving release-specific chart paths, Workspace descriptions, and preflight compatibility with the new exports unverified pending review by someone with SEP access.
No open issues 🎉
What changed in this PR
Fixes Enterprise Helm reference generation by selecting chart inputs from the source release’s platform chart version, supporting both v0.25.0 and v0.26.0 layouts. This provides the resolver and validator needed by the companion publication workflow.
Changes:
- Adds version-based chart selection and reports all missing or empty Helm inputs before generation.
- Configures retired chart cutoffs, the updated gateway path, and five Workspace description overrides.
- Adds tests for release-specific layouts and combined input validation errors.
| File | Description |
|---|---|
scripts/upstream-release/generate-helm-reference.test.mjs |
Tests chart selection across versions and combined missing-input reporting. |
scripts/upstream-release/generate-helm-reference.mjs |
Resolves release-specific charts and validates inputs before generation. |
.github/upstream-projects.yaml |
Defines chart version rules, gateway paths, and Workspace descriptions. |
Review effort: Balanced
blkt
approved these changes
Nov 4, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enterprise reference publication for v0.26.0 fails because the Helm configuration expects retired gateway operator charts and the former gateway source path. Resolve chart paths and description overrides from the source release's platform chart version, supporting both v0.25.0 and v0.26.0 layouts. Report all missing Helm inputs before generating pages.
Supply the five missing Workspace value descriptions for the published v0.26.0 chart through release-specific overrides. Generated references are left to the SEP publication workflow.
Type of change
Related issues/PRs
Companion SEP workflow hardening: https://github.com/stacklok/stacklok-enterprise-platform/pull/6235. Merge this PR first: SEP's updated preflight imports the chart resolver and input validator added here.
Validation
node --test scripts/upstream-release/generate-helm-reference.test.mjs: 13 tests passed.git diff --checkpassed.Submitter checklist
Content and formatting
Reviewer checklist
Content