Skip to content

ci(microvm): keep fixture signing out of the public Rekor log #2354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhrozek merged 1 commit into from
Oct 15, 2026
Merged

ci(microvm): keep fixture signing out of the public Rekor log #2354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/scripts/microvm-ci-release_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,10 +478,10 @@ COSIGN_PASSWORD= MICROVM_RELEASE_SIGNING_KEY="$scratch/publisher.key" "$sign" "$
for kind in runtime firmware execution-image; do
statement="$scratch/one/mecatl-$kind-linux-amd64.provenance.json"
bundle="$scratch/one/mecatl-$kind-linux-amd64.provenance.sigstore.json"
cosign verify-blob --key "$scratch/publisher.pub" --bundle "$bundle" "$statement" >/dev/null
cosign verify-blob --key "$scratch/publisher.pub" --insecure-ignore-tlog --bundle "$bundle" "$statement" >/dev/null
cp "$statement" "$scratch/tampered.provenance.json"
printf ' ' >>"$scratch/tampered.provenance.json"
if cosign verify-blob --key "$scratch/publisher.pub" --bundle "$bundle" "$scratch/tampered.provenance.json" >/dev/null 2>&1; then
if cosign verify-blob --key "$scratch/publisher.pub" --insecure-ignore-tlog --bundle "$bundle" "$scratch/tampered.provenance.json" >/dev/null 2>&1; then
echo "tampered $kind publisher evidence was accepted" >&2
exit 1
fi
Expand Down
4 changes: 3 additions & 1 deletion .github/scripts/sign-microvm-release-evidence.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ for provenance in "$assets"/*.provenance.json; do
--bundle "$bundle" "$provenance" >/dev/null
echo "Reusing verified signature bundle $(basename "$bundle")"
elif [ -n "${MICROVM_RELEASE_SIGNING_KEY:-}" ]; then
COSIGN_PASSWORD=${COSIGN_PASSWORD:-} cosign sign-blob --yes --key "$MICROVM_RELEASE_SIGNING_KEY" --bundle "$bundle" "$provenance"
# A throwaway test key: keep its signature out of the public Rekor log. The
# upload is worthless here and a retried POST can come back as a 409 conflict.
COSIGN_PASSWORD=${COSIGN_PASSWORD:-} cosign sign-blob --yes --use-signing-config=false --tlog-upload=false --key "$MICROVM_RELEASE_SIGNING_KEY" --bundle "$bundle" "$provenance"
else
cosign sign-blob --yes --bundle "$bundle" "$provenance"
fi
Expand Down
Loading