Unify transaction error handling and receipt checks - #819
Merged
Conversation
evgeny-stakewise
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
All
tx_manager.transact()call sites hand-rolled the same wrapper:try/except ContractCustomErrorwithdecode_custom_error, a genericexcept Exceptionwithformat_error, and anif tx_receipt is Nonecheck — with inconsistent log levels, inconsistent verbose dumps, and two sites with partial or no handling.This adds a shared
transact_checked()helper insrc/common/transaction.pythat normalizes reverts, RPC errors, and unconfirmed receipts into a loggedNone, and converts all 9 call sites to use it:logger.errorplus asettings.verboseexception dump everywhere (consolidate/withdrawals previously logged failures at info level).submit_harvest_transactiongains generic-exception handling it previously lacked.MulticallContractnow includesErrorMixin, sotx_aggregatereverts are decoded and logged instead of propagating undecoded.RuntimeErroron a revert instead of re-raisingContractCustomError; the loop aborts either way.HexStr | None.