Repository navigation
strut/run-workflow: parse a JSON-string input before launching on the peer - #135
Merged
Merged
Conversation
… string The job agent on swarm38 (run 1791645581902) called strut/run-workflow as a tool with `input` as a JSON string; launchOnPeer sent it verbatim and the peer's explore refused it (expected object, received string), twice. The builder's peer run_workflow and meta/run-workflow already coerce through coerceJsonArg; launchOnPeer now does too, covering every peer launch. coerceJsonArg moves to core.ts so peers.ts need not import authoring.ts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The job agent on swarm38 (run
1791645581902) calledstrut/run-workflowwithinputas a JSON string.launchOnPeersent it as-is, and the peer'sexplorerefused it twice withexpected object, received string.The builder's
run_workflow { peer }andmeta/run-workflowalready run tool args throughcoerceJsonArg.launchOnPeernow does too (input and params), so every peer launch is covered.coerceJsonArgmoves tocore.ts(re-exported fromauthoring.ts), sopeers.tsand the lib step don't importauthoring.ts.Test:
peers.test.tslaunches with a string input and params and checks the peer receives objects.npm test: 1416/1416 pass.