Skip to content

new commit - #18

Open
flansah wants to merge 7 commits into
masterfrom
json_file_database
Open

new commit#18
flansah wants to merge 7 commits into
masterfrom
json_file_database

Conversation

@flansah

@flansah flansah commented Feb 23, 2019

Copy link
Copy Markdown

No description provided.

@LanceGundersen
LanceGundersen requested review from Drbaltar and removed request for LanceGundersen February 24, 2019 03:56

@Drbaltar Drbaltar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Lansah,
Your JSON was missing a ']' at the end of the file. Also, I see that the filter functionality is already being done by the front-end that Lance set up so there is no need to pass in a search keyword. Finally, I would recommend combining the details and tv/movie overview into one file. See below for an example of what I am referring to:

{
"tv_shows":[
{
"tvShow_ID":0,
"isTV":true,
"rating":false,
"isWatched":false,
"originalTitle":"TV show Title",
"releaseDate":"2019-02-22",
"overview":"This TV show is about love",
"poster_path":null,
"trailer_path":null,
"vote_average":0,
"vote_count":0
}
],
"movies":[
{
"movieID":0,
"isTV":false,
"rating":false,
"isWatched":false,
"originalTitle":"Movie Title",
"releaseDate":"2019-02-22",
"overview":"This movie is about crime",
"poster_path":null,
"trailer_path":null,
"vote_average":0,
"vote_count":0
}
]
}

@LanceGundersen

Copy link
Copy Markdown
Member

@Drbaltar yes, like my devDB.json
line 28 (movie id)

"id": 1,

line 125 (tv id)
"id": 234,

@Drbaltar

Copy link
Copy Markdown
Contributor

Lance, are you talking about labeling the 'movieID' and 'tvShowID' to just 'id' for both?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants