Refactored ks_twosample to take in two slices instead of a mutable owned Vec<f64>#406
Refactored ks_twosample to take in two slices instead of a mutable owned Vec<f64>#406AshrafIbrahim03 wants to merge 4 commits into
Conversation
This reverts commit 1029458.
|
@AshrafIbrahim03 did you verify tests with all targets n features? |
|
I did not. I just reread through the contributing section of the README to see if it details how to run those, but I don't see it. How can I do that? |
|
probably you find out: Thanks, the call sites compile now. I checked the latest commit but three KS tests still fail. currently order is wrong. are you sure it should be like that? may you add some context to Pr ? |
|
Yes, just saw the last three tests fail, pushing a fix for it now! Some more context: basically we were talking about a contribution I could make in #405 , and it seemed like changing the ks sampling function to take a I also noticed the ks one sample function that I should probably bundle in this PR too! |
Through some discussion in #405 , it seemed like refactoring ks_twosample was needed. Basically just changed the function signature from:
to
This is more in line with what's in other files in the same folder.