perf: mark evaluate::polynomial #[inline]#420
Draft
agene0001 wants to merge 1 commit into
Draft
Conversation
Every in-crate caller passes a `const` coefficient slice, so with the length known at the call site LLVM fully unrolls the Horner fold - roughly 4x against the outlined loop when measured in isolation. Honest scope: LLVM was already inlining this within the crate, so `erf` timing does not move. The attribute makes that guaranteed rather than incidental, and extends it across codegen units and to external callers of this public function. Lowest priority of the series.
agene0001
added a commit
to agene0001/statrs
that referenced
this pull request
Jul 26, 2026
Brings the integration branch to the exact union of PRs statrs-dev#407-statrs-dev#420: adds the NaN regression test written for statrs-dev#407 (statrs-dev#163), relocates the Geometric near-1 test to match the prec PR, and aligns two comment/tolerance details.
agene0001
marked this pull request as draft
July 27, 2026 08:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every in-crate caller passes a
constcoefficient slice, so with the length known at the call site LLVM fully unrolls the Horner fold — ~4x against the outlined loop when measured in isolation.Honest scope: LLVM already inlines this within the crate, so in-crate timings don't move. The attribute makes that guaranteed rather than incidental, and extends it across codegen units and to external callers of this public function. Lowest priority of the series — feel free to close if not wanted.
🤖 Generated with Claude Code