Repository navigation
Conversation
Add a VERSION constant and a version() entrypoint so clients and indexers can detect which behaviour a deployed subscription contract has. The doc comment records the rule: bump VERSION on any change to the storage layout or to how an entrypoint behaves. A test checks that version() returns the constant. Closes stellar-sub#43 Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Add get_by_subscriber_page(subscriber, start, limit). It reads one slice of the subscriber's index, so large histories no longer have to be read in one call. limit is capped at MAX_PAGE_LIMIT (50), and a page past the end is empty. get_by_subscriber is kept unchanged for compatibility. A test checks that pages run end to end with no gaps or repeats, and that a huge limit is capped. Closes stellar-sub#44 Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
…r-sub#41) Add a property test that runs random registrations and valid updates and, after every step, checks the incremental stats against values recomputed from all stored records: total subscriptions, active count and charged volume. The registry gains proptest as a dev-dependency. Closes stellar-sub#41 Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Advance the ledger into the threshold window, then read a record and the id list, and check that both persistent TTLs grew. Closes stellar-sub#42 Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
|
@amaka105 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subscription and registry: version(), paged subscriber listing, stats and TTL tests
proptestas a registry dev-dependency.VERSIONandversion()to the subscription contract, with a rule in the doc comment for when to bump it.get_by_subscriber_page(subscriber, start, limit).limitis capped atMAX_PAGE_LIMIT(50), andget_by_subscriberis unchanged.Closes #41
Closes #42
Closes #43
Closes #44
Notes for review:
Cargo.lockupdated for the newproptestdev-dependency.🤖 Generated with Claude Code