Repository navigation
Conversation
… once (stellar-sub#49) Add batch_charge(merchant, ids). Every id goes through the full charge checks (CAP, INTERVAL and REVOCATION), and the merchant authorizes once for the call. The batch is all or nothing: the first id that fails returns its error and the whole call is rolled back, so nothing is charged. This is deliberate. An error returned from an internal call to charge does not roll back its writes, so skip-and-report would leave partial state. At most MAX_BATCH (20) ids are accepted, otherwise BatchTooLarge is returned. Tests cover a full batch, rollback when one id fails, another merchant's id, and the size limit. Closes stellar-sub#49 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
@edwina105 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subscription: batch_charge
Adds
batch_charge(merchant, ids)so a merchant can charge many subscriptions in one transaction.chargechecks (CAP, INTERVAL, REVOCATION), and the merchant authorizes once.chargedoes not roll back that call's writes.MAX_BATCH(20) ids are accepted, otherwiseBatchTooLarge.Closes #49
The issue was marked "Needs design" and asked for maintainer agreement first. This PR implements it at the contributor's request, so maintainers may want to confirm the all-or-nothing choice and the batch size.
The code has not been compiled or run. Please check it in CI.
🤖 Generated with Claude Code