Repository navigation
Conversation
|
@m1s0g1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses four issues with comprehensive implementations:
Changes by Issue
Issue #67: Per-Merchant Stats Registry
MerchantStatstype tracking subscriptions, active subscriptions, and total charged volume per merchantregister_subscriptionto initialize merchant statsupdate_subscriptionto maintain merchant stats alongside global statsget_merchant_stats(merchant)public functionIssue #66: Inactive Plans View
get_inactive_plans_by_merchant()returning inactive plans oldest firstget_inactive_plans_by_merchant_count()helper functionIssue #65: Plan Description Design
Design Decision: Option 1 - New field plus mirror update (chosen for coherence and simplicity)
description: Option<String>to Plan in both plan and subscription contractsNoneIssue #56: Token in Charged Event
token: Addressfield to Charged eventTesting
All changes include comprehensive test coverage:
Closes
Closes #67
Closes #66
Closes #65
Closes #56