Skip to content

Update Import transaction's UI - #2149

Merged
jeesunikim merged 13 commits into
mainfrom
update-multisig-sign-view-signatures
Aug 21, 2026
Merged

Update Import transaction's UI#2149
jeesunikim merged 13 commits into
mainfrom
update-multisig-sign-view-signatures

Conversation

@jeesunikim

@jeesunikim jeesunikim commented Jul 8, 2026

Copy link
Copy Markdown
Contributor
  • Remove labels around <Signatures/> per design
  • Don't skip "Sign" step on behalf of user when imported transaction has a signature. Previously, we skipped it to Submit so that its signature can be verified first; however, it's too much of handholding. Instead, display a Signatures table in Sign transaction and let them decide
  • We skip "Sign" and go directly to "Submit" if offline check can verify that all required signatures are signed for the tx
  • Submit transaction's details to include signature verification
  • Sign transaction to include decoded XDR in JSON (included a language dropdown to switch JSON <> XDR)
  • Replaced "unrecognized signers" (multisig that can't be verified offline) text with "Existing signer (unverified)"

TX samples:

  • tx with no signatures: AAAAAgAAAADSBFf5wA+BWEc1jDmwvbVupg1OrohBSRvHtEUG0FmTSwAAAGQAJoazAAAAFgAAAAAAAAAAAAAAAQAAAAAAAAABAAAAALeAVmIAOom1tFe0PE2ZHWOn+hSTZuYY136c6XpoWKBVAAAAAAAAAAAC+vCAAAAAAAAAAAA=
  • tx with multisig as a source within operation: AAAAAgAAAADSBFf5wA+BWEc1jDmwvbVupg1OrohBSRvHtEUG0FmTSwAAAGQAJoazAAAAFgAAAAAAAAAAAAAAAQAAAAEAAAAAeH8YX2LLiZESynVxH8gRYbkGo9kp9WvTIKpupYBaGOwAAAABAAAAALeAVmIAOom1tFe0PE2ZHWOn+hSTZuYY136c6XpoWKBVAAAAAAAAAAAC+vCAAAAAAAAAAAGAWhjsAAAAQH33HKhPjIpWCuTTg0UwM2za+/cipMaDdrFliHBTmRcNRck0XW3Y5AYY4xu2+u/cUEzShd+1V2b7sRZdO8adGwg=
  • tx with multisig: AAAAAgAAAADSBFf5wA+BWEc1jDmwvbVupg1OrohBSRvHtEUG0FmTSwAAAGQAJoazAAAAFwAAAAAAAAAAAAAAAQAAAAAAAAABAAAAACHl1hdsb68IKFCwYxh+DyTYAFNPPQYeXIdl3VD5t/10AAAAAAAAAAAC+vCAAAAAAAAAAAGAWhjsAAAAQHj3NcCOYERqouBvL0Uv3rQ91qNkxi0H28W9g2d8MA4pRAjzU9q1v3mDsiA3EJMaxMhyy4JISzC8OXkqBiqNJQI=
  • tx with all required signatures: AAAAAgAAAADSBFf5wA+BWEc1jDmwvbVupg1OrohBSRvHtEUG0FmTSwAAAGQAJoazAAAAFgAAAAAAAAAAAAAAAQAAAAEAAAAAeH8YX2LLiZESynVxH8gRYbkGo9kp9WvTIKpupYBaGOwAAAABAAAAALeAVmIAOom1tFe0PE2ZHWOn+hSTZuYY136c6XpoWKBVAAAAAAAAAAAC+vCAAAAAAAAAAAKAWhjsAAAAQH33HKhPjIpWCuTTg0UwM2za+/cipMaDdrFliHBTmRcNRck0XW3Y5AYY4xu2+u/cUEzShd+1V2b7sRZdO8adGwjQWZNLAAAAQJ+YFFwUakiYWFhB2jKpXcLRTx0cbhni+6in7ui/vsZ037XGCUq9nm2yjNSamzO00qEvkGoKpAEKdpSTnakIDwM= (skips to submit)

Screenshots:

  • Signature under Sign step
signatures-section-sign
  • Signature under Import
signature-under-import
  • "Sign transaction" step to include decoded details
Screenshot 2026-07-07 at 6 12 41 PM
  • "Submit transaction" step to include verified signature
Screenshot 2026-07-07 at 6 12 56 PM

@github-project-automation github-project-automation Bot moved this to Backlog (Not Ready) in DevX Jul 8, 2026
@stellar-jenkins-ci

Copy link
Copy Markdown

1 similar comment
@stellar-jenkins-ci

Copy link
Copy Markdown

@jeesunikim jeesunikim linked an issue Jul 8, 2026 that may be closed by this pull request
@jeesunikim
jeesunikim force-pushed the update-multisig-sign-view-signatures branch from 3705696 to 6fe3e40 Compare August 6, 2026 06:01
@stellar-jenkins-ci

Copy link
Copy Markdown

Something went wrong with PR preview build please check

@stellar-jenkins-ci

Copy link
Copy Markdown

@jeesunikim
jeesunikim marked this pull request as ready for review August 6, 2026 17:11
Copilot AI balanced review requested due to automatic review settings August 6, 2026 17:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates transaction import/sign/submit UI to expose signatures, decoded XDR, and verification details while improving stale-state handling.

Changes:

  • Adds signature context and JSON/XDR views.
  • Adjusts multisig routing and messaging.
  • Adds regression tests and footer layering fixes.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
tests/e2e/signStepContent.test.ts Updates signed-result assertions.
tests/e2e/importMultisigSubmit.test.ts Tests multisig submission routing.
tests/e2e/buildFlowResetOnEdit.test.ts Tests stale-signature reset.
src/styles/globals.scss Raises submit dropdown layering.
src/helpers/checkRequiredSignatures.ts Revises offline completeness semantics.
src/constants/networkLimits.ts Refreshes generated limits.
src/components/TransactionFlowFooter/styles.scss Changes footer stacking.
src/app/(sidebar)/transaction/styles.scss Removes legacy XDR styles.
src/app/(sidebar)/transaction/import/page.tsx Adds signature context and submission fallback.
src/app/(sidebar)/transaction/import/components/SignStepSignatureContext.tsx Adds signature-status panel.
src/app/(sidebar)/transaction/import/components/ImportStepContent.tsx Simplifies import messaging.
src/app/(sidebar)/transaction/components/SubmitStepContent.tsx Adds decoded transaction verification view.
src/app/(sidebar)/transaction/components/SignStepContent.tsx Adds hash and JSON/XDR display.
src/app/(sidebar)/transaction/components/Signatures.tsx Revises multisig terminology.
src/app/(sidebar)/transaction/build/page.tsx Resets stale downstream state.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/app/(sidebar)/transaction/components/SignStepContent.tsx Outdated
Comment thread src/app/(sidebar)/transaction/import/page.tsx Outdated
Comment thread src/app/(sidebar)/transaction/styles.scss
Comment thread src/constants/networkLimits.ts Outdated
Comment thread src/components/TransactionFlowFooter/styles.scss
Comment thread src/app/(sidebar)/transaction/components/SubmitStepContent.tsx
@jeesunikim
jeesunikim force-pushed the update-multisig-sign-view-signatures branch from d38eb6a to 2858900 Compare August 10, 2026 07:09
@stellar-jenkins-ci

Copy link
Copy Markdown

1 similar comment
@stellar-jenkins-ci

Copy link
Copy Markdown

@jeesunikim
jeesunikim force-pushed the update-multisig-sign-view-signatures branch from f981640 to aa7bbe5 Compare August 20, 2026 22:49
@stellar-jenkins-ci

Copy link
Copy Markdown

@jeesunikim
jeesunikim requested a review from quietbits August 20, 2026 23:56
@stellar-jenkins-ci

Copy link
Copy Markdown

@quietbits quietbits left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR, UI suggestion to hide "All" chip if there is only one operation type.

Image

@jeesunikim
jeesunikim merged commit adbdc50 into main Aug 21, 2026
7 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog (Not Ready) to Done in DevX Aug 21, 2026
@jeesunikim
jeesunikim deleted the update-multisig-sign-view-signatures branch August 21, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Improve "Import transaction"

3 participants