Skip to content

Add 'operations' and 'signatures' tab in import transaction - #2179

Merged
jeesunikim merged 7 commits into
mainfrom
issue-2147
Aug 20, 2026
Merged

Add 'operations' and 'signatures' tab in import transaction#2179
jeesunikim merged 7 commits into
mainfrom
issue-2147

Conversation

@jeesunikim

@jeesunikim jeesunikim commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

XDR for testing:

  • Invoke contract XDR: AAAAAgAAAAC42ZMzovB7OFb2JLzYBCD8Cca30F6pytmioKolDDbksQAAAMgABUj7AAAABAAAAAEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAEAAAAAAAAAGAAAAAAAAAABOzV9wT7i6mhnNOf30s+wnh3bvdKZawv5UcjZX+ujBDsAAAAFaGVsbG8AAAAAAAABAAAADwAAAAR0ZXN0AAAAAAAAAAEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=
  • Lots of operations XDR:
AAAAAgAAAABOoGeOE2jFIJ/Ya0mBq/BBdk8dvRgUkY5swIKyjc9OtQADgnAAECzEAAAAAQAAAAEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABcAAAAAAAAAAAAAAACXlGN76T6NQcaUJxbEkH3mi1HHWsHnLqMDdlLl9NlJgQAAAAAF9eEAAAAAAAAAAAEAAAAAl5Rje+k+jUHGlCcWxJB95otRx1rB5y6jA3ZS5fTZSYEAAAABVVNEQwAAAABnAj9Nl60oxvi+eJSta3cdY/V2PkpDL69joQGRY+Mx3AAAAAA75xVAAAAAAQAAAAA55ZjOXdOOulfzeLPXjLDLdplq/5HGjapWAXjGSkdAkwAAAAEAAAAAl5Rje+k+jUHGlCcWxJB95otRx1rB5y6jA3ZS5fTZSYEAAAAAAAAAAACYloAAAAAAAAAADQAAAAAAAAAAHc1lAAAAAACXlGN76T6NQcaUJxbEkH3mi1HHWsHnLqMDdlLl9NlJgQAAAAFVU0RDAAAAAGcCP02XrSjG+L54lK1rdx1j9XY+SkMvr2OhAZFj4zHcAAAAAAOThwAAAAABAAAAAUVVUkMAAAAAZwI/TZetKMb4vniUrWt3HWP1dj5KQy+vY6EBkWPjMdwAAAAAAAAAAgAAAAAAAAAAI8NGAAAAAACXlGN76T6NQcaUJxbEkH3mi1HHWsHnLqMDdlLl9NlJgQAAAAFVU0RDAAAAAGcCP02XrSjG+L54lK1rdx1j9XY+SkMvr2OhAZFj4zHcAAAAAAOThwAAAAAAAAAAAAAAAAMAAAABVVNEQwAAAABnAj9Nl60oxvi+eJSta3cdY/V2PkpDL69joQGRY+Mx3AAAAAAAAAC5KJgAgAAA9ZkAAYagAAAAAAAAAAAAAAAAAAAADAAAAAAAAAABVVNEQwAAAABnAj9Nl60oxvi+eJSta3cdY/V2PkpDL69joQGRY+Mx3AAAALkomACAAAD1mQABhqAAAAAAAAAAAAAAAAAAAAAEAAAAAVVTREMAAAAAZwI/TZetKMb4vniUrWt3HWP1dj5KQy+vY6EBkWPjMdwAAAAAAAAAAAX14QAAAAABAAAAAQAAAAAAAAAFAAAAAAAAAAAAAAAAAAAAAQAAAAIAAAABAAAAAQAAAAEAAAACAAAAAQAAAAMAAAABAAAAC2V4YW1wbGUuY29tAAAAAAEAAAAAOeWYzl3TjrpX83iz14ywy3aZav+Rxo2qVgF4xkpHQJMAAAABAAAAAAAAAAYAAAABVVNEQwAAAABnAj9Nl60oxvi+eJSta3cdY/V2PkpDL69joQGRY+Mx3AAAAAAdzWUAAAAAAAAAAAgAAAAAl5Rje+k+jUHGlCcWxJB95otRx1rB5y6jA3ZS5fTZSYEAAAAAAAAACgAAAAZzb25lc28AAAAAAAEAAAAFaGVsbG8AAAAAAAAAAAAACwAQLMQAAAAsAAAAAAAAAA4AAAAAAAAAAA7msoAAAAABAAAAAAAAAACXlGN76T6NQcaUJxbEkH3mi1HHWsHnLqMDdlLl9NlJgQAAAAAAAAAAAAAADwAAAACSmyC3PuXuwMm19bPgsKPz06Hn4PjiotDJuKf25dTDsgAAAAAAAAAQAAAAAJeUY3vpPo1BxpQnFsSQfeaLUcdawecuowN2UuX02UmBAAAAAAAAABEAAAAAAAAAEgAAAAAAAAAAAAAAAJeUY3vpPo1BxpQnFsSQfeaLUcdawecuowN2UuX02UmBAAAAAAAAABIAAAAAAAAAAQAAAACXlGN76T6NQcaUJxbEkH3mi1HHWsHnLqMDdlLl9NlJgQAAAAFVU0RDAAAAAGcCP02XrSjG+L54lK1rdx1j9XY+SkMvr2OhAZFj4zHcAAAAAAAAABMAAAABVVNEQwAAAABnAj9Nl60oxvi+eJSta3cdY/V2PkpDL69joQGRY+Mx3AAAAACXlGN76T6NQcaUJxbEkH3mi1HHWsHnLqMDdlLl9NlJgQAAAAAC+vCAAAAAAAAAABUAAAAAl5Rje+k+jUHGlCcWxJB95otRx1rB5y6jA3ZS5fTZSYEAAAABVVNEQwAAAABnAj9Nl60oxvi+eJSta3cdY/V2PkpDL69joQGRY+Mx3AAAAAIAAAABAAAAAAAAABa3nJKwNKbVBvK27jMByobyd9EmNMSm1Ln4jOnuzBDK3QAAAAA7msoAAAAAAHc1lAAAAAABAAAAAgAAAAIAAAABAAAAAAAAABe3nJKwNKbVBvK27jMByobyd9EmNMSm1Ln4jOnuzBDK3QAAAAAdzWUAAAAAAAX14QAAAAAAC+vCAAAAAAAAAAACjc9OtQAAAEBAUe674xxYAdBuzV6mfQWpCjhqmzf5Pqv9nAZIr/3E7dGkFnASuXFwuyA7dCJIthF8PmmMMQ/tiZWa8rdh46sCSkdAkwAAAEDMSugpOlJQY21+KoMUlsqTi4lT3vzM52f4lOCin5kxuHsCDJkr+EkZDXxAOwLJZJ21NsSIdeORpFTZUuo7dQMF
Screenshot 2026-08-18 at 6 10 10 PM Screenshot 2026-08-18 at 6 10 03 PM

@github-project-automation github-project-automation Bot moved this to Backlog (Not Ready) in DevX Aug 18, 2026
@stellar-jenkins-ci

Copy link
Copy Markdown

1 similar comment
@stellar-jenkins-ci

Copy link
Copy Markdown

@stellar-jenkins-ci

Copy link
Copy Markdown

@jeesunikim
jeesunikim marked this pull request as ready for review August 19, 2026 01:20
Copilot AI balanced review requested due to automatic review settings August 19, 2026 01:20
@stellar-jenkins-ci

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Operations and Signatures tabs to the transaction import overview and extracts reusable classic-operation rendering.

Changes:

  • Adds operation filtering and signature-tab navigation.
  • Extracts the dashboard operation list into a shared component.
  • Updates styling and end-to-end coverage.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/components/ClassicOperationsList/index.tsx Adds reusable operation rendering and pagination.
src/components/ClassicOperationsList/styles.scss Styles shared operation cards.
src/app/(sidebar)/transaction/components/Operations.tsx Adds operation decoding and filtering.
src/app/(sidebar)/transaction/components/Signatures.tsx Adapts signatures for tab embedding.
src/app/(sidebar)/transaction/import/components/ImportStepContent.tsx Adds Operations and Signatures tabs.
src/app/(sidebar)/transaction/styles.scss Styles operation filter controls.
src/app/(sidebar)/transaction/dashboard/components/ClassicOperations.tsx Uses the shared operation list.
src/app/(sidebar)/transaction/dashboard/styles.scss Removes migrated operation styles.
tests/e2e/importTransactionPage.test.ts Tests tab switching and filtering.
tests/e2e/txDashClassicOperations.test.ts Updates shared component selectors.
Suppressed comments (1)

src/components/ClassicOperationsList/index.tsx:161

  • This icon-only pagination button also has no accessible name. Add an aria-label so its action is available to assistive technology.
            <Button
              variant="tertiary"
              size="sm"
              icon={<Icon.ArrowRight />}
              onClick={handleNextPage}
              disabled={currentPage === totalPageCount}
            />

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/components/ClassicOperationsList/index.tsx
Comment thread src/app/(sidebar)/transaction/components/Operations.tsx
@stellar-jenkins-ci

Copy link
Copy Markdown

jeesunikim and others added 2 commits August 18, 2026 18:40
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@stellar-jenkins-ci

Copy link
Copy Markdown

@jeesunikim jeesunikim linked an issue Aug 19, 2026 that may be closed by this pull request
@jeesunikim
jeesunikim requested a review from quietbits August 19, 2026 01:46
@stellar-jenkins-ci

Copy link
Copy Markdown

Comment thread src/app/(sidebar)/transaction/components/Operations.tsx
Comment thread src/app/(sidebar)/transaction/components/Operations.tsx
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@stellar-jenkins-ci

Copy link
Copy Markdown

@jeesunikim
jeesunikim merged commit 5e3d786 into main Aug 20, 2026
7 of 10 checks passed
@jeesunikim
jeesunikim deleted the issue-2147 branch August 20, 2026 18:01
@github-project-automation github-project-automation Bot moved this from Backlog (Not Ready) to Done in DevX Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Bring operation details into /import

3 participants