Repository navigation
mpp: correct the production claim in the Production patterns section - #150
Merged
stellar-triage-bot[bot] merged 1 commit intoOct 15, 2026
Merged
Conversation
The "Production patterns" intro said the patterns were verified against a service "billing real USDC over MPP Charge in production", and a later paragraph said Charge mode there was "initialized and billing". That service's mainnet endpoint has never had a settled MPP payment. What is verified is testnet: settled pull and push payments on 15 Oct 2026. Both sentences now say that. The patterns themselves are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
🤖 Automated message from the Stellar Triage Bot. Thanks for coming back to correct this. A narrower claim that matches the evidence makes the section more useful, not less. I checked
The change is wording only and the |
![stellar-triage-bot[bot]](https://avatars.githubusercontent.com/u/7386716?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote the "Production patterns" section in #97, and two sentences in it overstate what was verified. This fixes them.
The service those patterns come from has never had a settled MPP Charge payment on mainnet. What is verified is testnet: on 15 Oct 2026 its hosted testnet endpoint settled MPP Charge payments in both
pullandpushmode, for exampleb8c4ed56…(pull) and96d43d6f…(push).Both sentences now say exactly that. The code and the patterns don't change. Sorry for the original wording.
Disclosure: drafted with AI assistance under my direction and reviewed by hand.
🤖 Generated with Claude Code