Use GetLedgerRaw in getLatestLedger endpoint - #941
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Optimizes getLatestLedger by returning stored ledger metadata bytes directly, avoiding unnecessary XDR round-trips.
Changes:
- Adds
GetLedgerRawto ledger readers and mocks. - Reuses raw header parsing in database reads.
- Updates the endpoint and tests for raw metadata.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
cmd/stellar-rpc/internal/db/ledger.go |
Adds raw ledger retrieval and header parsing. |
cmd/stellar-rpc/internal/db/mocks.go |
Implements raw retrieval in the database mock. |
cmd/stellar-rpc/internal/methods/get_latest_ledger.go |
Builds responses from raw metadata and parsed headers. |
cmd/stellar-rpc/internal/methods/get_latest_ledger_test.go |
Updates test reader behavior for raw metadata. |
cmd/stellar-rpc/internal/methods/mocks.go |
Extends the methods mock with GetLedgerRaw. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Shaptic
approved these changes
Aug 21, 2026
Shaptic
reviewed
Aug 21, 2026
Shaptic
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Uses the new raw-bytes patterning used in
getLedgeringetLatestLedger:GetLedgerRaw(ctx, sequence) ([]byte, xdr.LedgerHeaderHistoryEntry, bool, error)toLedgerReadergetLatestLedgerhandler to callGetLedgerRawGetLedgerRawWhy
getLatestLedgercurrently wastes time calling GetLedgers to get a singleLedgerCloseMeta, which causes anUnmarshalto XDR. The handler then marshals this XDR to binary. On each call, we pay for a ~2.8MbUnmarshalandMarshalthat can be completely bypassed.Known limitations
N/A