Repository navigation
Merge development into main - #87
Merged
Merged
Conversation
* Exit on invalid date * Raise exception on future date * Add test for checking future date raise exception
…nd-models Refactor knowledge base and models
…el-call Patch bin aip alpha 7 model call
* Catch ValueError once not every time * Rename st_time to start_time * _rebuild: add end_date argument to * Change logging level to debug
* Fix logger name to smth meaningful * Add subparser * Migrate to 'run-models' command * Migrate to 'rebuild-kb' command * Validate start_date once, not on every command * Set models default when not specified * Update to reflect change in variable names * Add some commands to the README
* Rename date_day to start_date * Explicit calling parameters on run_model * Add end-date with default values * Validate start and end * Iterate through dates
Validate data and raise exception
Fix and simplify README usage instructions
Fix exit codes, date checks and knowledge base rebuild end date
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings
mainup to date withdevelopment(31 commits).Command line
bin/aipnow uses commands:run-modelsandrebuild-kb(Add scalable AIP arguments #74).run-modelsaccepts--start-dateand--end-dateand runs all models for every day in that range (Add option to run all models between two dates #76).rebuild-kb --start-daterebuilds the attacker history from a date (Knowledge base rebuild take start and end dates via arguments #72).Models
Documentation
Breaking change
The
--dateoption was removed.bin/aip --date YYYY-MM-DDnow fails. Use:Running
bin/aipwith no options still runs all models for today.Versioning
On merge to
main, the Auto Tag workflow bumps the minor version by default (v3.0.0 → v3.1.0). Because of the breaking change above, consider adding#majorto the merge commit message (v4.0.0).