Skip to content

Align auth response CSP and add Strava sign-in fallback #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
a0a7 merged 9 commits into from
May 30, 2026
Merged

Align auth response CSP and add Strava sign-in fallback #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
75c2c77
Add CSP headers and sign-in fallback
Copilot May 30, 2026
a219e3d
Improve Strava connect accessibility
Copilot May 30, 2026
ac443c0
Refine Strava link key handling
Copilot May 30, 2026
495836b
Simplify Strava link accessibility
Copilot May 30, 2026
4f6f53c
Use form submit fallback for Strava sign-in
Copilot May 30, 2026
3b70aec
Handle Strava sign-in via form submit
Copilot May 30, 2026
9505a8c
Align Strava button focus styles
Copilot May 30, 2026
0e09d69
Add Strava button label
Copilot May 30, 2026
a3a6100
Refactor CSP header constant
Copilot May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion src/hooks.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,24 @@
export { handle } from './lib/auth/authHandler';
import { sequence } from '@sveltejs/kit/hooks';
import type { Handle } from '@sveltejs/kit';
import { handle as authHandle } from './lib/auth/authHandler';

const contentSecurityPolicy = [
"default-src 'self' blob: data: https://*.basemaps.cartocdn.com",
"font-src 'self'",
"img-src 'self' https://*.basemaps.cartocdn.com data: blob:",
"object-src 'none'",
"script-src 'self' 'unsafe-inline' https://static.cloudflareinsights.com blob: data:",
"style-src 'self' 'unsafe-inline'"
].join('; ');
Comment on lines +5 to +12

const securityHeaders: Handle = async ({ event, resolve }) => {
const response = await resolve(event);

response.headers.set('X-Content-Type-Options', 'nosniff');
response.headers.set('X-Frame-Options', 'DENY');
response.headers.set('Content-Security-Policy', contentSecurityPolicy);

return response;
};

export const handle = sequence(securityHeaders, authHandle);
18 changes: 12 additions & 6 deletions src/lib/components/sidebar/ConnectPanel.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<script lang="ts">
import * as Card from '$lib/components/ui/card';
import Button from '$lib/components/ui/button/button.svelte';
import * as Alert from '$lib/components/ui/alert'; // @ts-expect-error: this import does exist
import { signIn } from '@auth/sveltekit/client';
import '$lib/components/sidebar/svg-styles.css';
Expand All @@ -23,12 +22,19 @@
{/if}
</Card.Header>
<Card.Content>
<Button
class="bg-[#FC4C02] hover:bg-[#d14002] flex items-center mx-auto px-0 h-10 my-3"
on:click={() => signIn('strava')}
<form
action="/auth/signin/strava"
method="get"
on:submit|preventDefault={() => signIn('strava')}
>
<img src="img/icon/connect_with_strava.svg" alt="Connect with Strava" class="h-14" />
</Button>
<button
type="submit"
class="bg-[#FC4C02] hover:bg-[#d14002] focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-offset-2 focus-visible:ring-ring disabled:pointer-events-none disabled:opacity-50 flex items-center mx-auto px-0 h-10 my-3"
aria-label="Connect with Strava"
>
<img src="img/icon/connect_with_strava.svg" alt="Connect with Strava" class="h-14" />
</button>
</form>
</Card.Content>
<Card.Footer>
<Alert.Root>
Expand Down
Loading