Repository navigation
fix(lyrics): report collected lyrics truthfully - #272
Merged
Merged
Conversation
streambinder
force-pushed
the
feat/sdd-onboarding
branch
from
October 26, 2026 13:32
53feee0 to
dd68c89
Compare
streambinder
force-pushed
the
feat/lyrics-reporting
branch
from
October 26, 2026 13:32
60143b1 to
a5a40bc
Compare
streambinder
force-pushed
the
feat/sdd-onboarding
branch
from
October 26, 2026 13:38
dd68c89 to
c334ef5
Compare
streambinder
force-pushed
the
feat/lyrics-reporting
branch
2 times, most recently
from
October 26, 2026 13:45
c37cbba to
3af1ddb
Compare
A lyrics text with leading blank lines read as missing in the run output and in show.
streambinder
force-pushed
the
feat/lyrics-reporting
branch
from
October 26, 2026 13:46
3af1ddb to
91d84f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is cycle 001 of the specification workflow and stacks on the onboarding pull request. The artifacts live in
specs/001-lyrics-reporting/.The investigation in the specification disproved the first reading of the report. The search had found the lyrics and the persistence had stored the frame: the synchronization itself had written the lyrics cache during the run. The lyrics text of one composer starts with a blank line, and both reporting sites reduced the value to its first line, so a present value read as not found in the run output and as unset in
show.The change normalizes a lyrics text once at the lyrics boundary:
Searchstrips leading blank lines from the merged result before the cache write, normalizes a legacy cache entry on read, and counts a blank-only entry as a miss;Getstrips the same way. The collect log line and theshowLyrics row now excerpt the first non-empty line through a newsys.FirstContentLine, so the fallback fires only for an actually empty value. The choice rules, the failure accounting, and the frame format stay unchanged.Verification: the full suite passes locally with the race detector and the per-package coverage gate (cmd 98.1 percent, lyrics 96.8 percent, sys 94.7 percent), with new tests for the normalization, the legacy cache, the stored frame in
show, and the end-to-end run output. No real track, artist, or source page is named, per section 24 of the standard.