Repository navigation
feat(provider): remove qobuz provider - #274
Merged
Merged
Conversation
The terminology lint of the whole codebase requires the empty line term over blank line.
The temporary path in the Path row contains the test name and matched first.
The only stream proxy is gone and the official API needs a credentialed account.
streambinder
force-pushed
the
feat/drop-qobuz
branch
from
October 26, 2026 21:43
12a667c to
cae5278
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the Qobuz provider entirely:
provider/qobuz.go, its tests, the harness stubs for the Qobuz and dabmusic endpoints, and every mention in the docs and the architecture memory. YouTube remains the only search provider.Rationale: the third-party stream proxy the provider relied on is no longer reachable by programmatic clients, and the official API serves full streams only to accounts with a streaming entitlement. Rather than emulating a client or proxying credentials, the provider is dropped.
Notes:
providerpackage coverage stays at 98.2%.The partial-failure path of
Searchstays covered through a stub failing provider inprovider_test.go.Known unrelated failure:
TestCmdShowLyricsLeadingBlankLinesincmdalready fails on master at the base commit of this branch; it is not affected by this change.The super-linter failure on this PR is also pre-existing: every error is textlint terminology in
specs/001-lyrics-reporting/(from the base commit), none in files this change touches. Thegolangci-lintandgofumptchecks pass.