Skip to content

Fix/u2eq preflight dedup - #118

Merged
kenjudy merged 2 commits into
mainfrom
fix/u2eq-preflight-dedup
Aug 31, 2026
Merged

kenjudy merged 2 commits into
mainfrom
fix/u2eq-preflight-dedup

Conversation

@kenjudy

@kenjudy kenjudy commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

No description provided.

kenjudy and others added 2 commits August 31, 2026 14:50
calibration/observations.json: 30 observation records share the same JSON
schema -- a single repeated structure with nothing to refactor. Without this
exclusion, jscpd reports ~4.8% duplication, nearly all from this one file.
This follows the same rationale as the built-in DUPLICATE_IGNORE_PATTERNS
entries (vendored and generated files repeat by design).

.github/: CI workflow definitions repeat setup steps across jobs by design,
same as the built-in vendored/generated exclusions.

Measured effect: duplication falls from ~4.8% to ~1.57% (test fixture
patterns sharing structure across workflow test files), below the 2% healthy
band. The 1.57% is genuine; the 4.8% was calibration-data noise.

Note the deliberate near-collision: a tracked .codemetrics.json file and an
ignored .codemetrics/ output directory coexist -- different filesystem
entries, shared prefix intentional (see CLAUDE.md Output Location section).

Closes code-quality-metrics-0a3m

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… check

A per-ref loop summing git rev-list --count results counted shared commits
once per branch, producing a 21x overcount on repositories with many late-
diverging branches (596 unique commits reported as 12,450). Passing all refs
to a single rev-list call lets git deduplicate shared history, matching what
fetchBranchCommits actually returns.

Closes code-quality-metrics-u2eq.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

PR Analysis

Size: small (based on production code)
Production Code: 28 lines (2 files)
Test Code: 28 lines (1 files)
Total: 56 lines (3 files)
Test-to-Production Ratio: 1.00:1
No size or quality concerns.

Commit Analysis

Total Commits: 2
Average Commit Size: 14 production lines
Average Files per Commit: 1.5

Metric Value
Large commits (>100 prod lines) 0/2 (0%)
Sprawling commits (>5 files) 0/2 (0%)
Test/prod co-change rate 1/2 (50%)
Message quality 2/2 (100%)
Median net additions ratio 0.66
Test-only commits 0
Production-only commits 1

Commit Details

3993820 Ken Judy (8/31/2026)
chore: commit .codemetrics.json to make duplication result reproducible
6 prod lines, 1 files

f09f490 Ken Judy (8/31/2026)
fix: deduplicate shared ancestry in getExpectedCommitCount pre-flight check
22 prod lines, 2 files [test+prod]

Test Coverage

Test-to-Production Ratio: 1.00:1 (no calibrated target for this ratio; reported descriptively)

DORA Capability Assessment

Archetype: harmonious-high-achiever
Strong batch discipline, test coverage, and message quality. AI tools likely amplifying positive outcomes.

Capability Metric Value Target
Small Batches Large commit % 0% <18% (no critical band established)
Small Batches Sprawling commit % 0% <18% (no critical band established)
Version Control Test/prod co-change rate 50% >23% (no critical band established)
Version Control Message quality 100% no band, see spec
AI Risk Signal Net additions ratio (median) 0.66 no band, see spec
Sample size (2 commits) is below the 5-commit convention for a rate verdict (code-quality-metrics-w9f): large-commit %, sprawling-commit % and test/prod co-change rate are reported below without a pass/fail judgement.
Automated by Code Metrics Workflow

@kenjudy
kenjudy merged commit d24c525 into main Aug 31, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant