Fix multiline expression index handling - #303
Draft
Pybsama wants to merge 1 commit into
Draft
Conversation
Allow CREATE INDEX rewrites to span newlines preserved by pg_get_indexdef, and cover both concurrent creation and non-concurrent plan validation. Fixes stripe#253
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pg_get_indexdefcan preserve newlines inside expression index definitions. The existing anchored rewrite uses.*, which does not match newlines in Go, so converting a valid definition toCREATE INDEX CONCURRENTLYfails. The same conversion is also used while validating plans with concurrent index operations disabled.This change enables dot-all matching only for the existing regex, preserving its anchors, case sensitivity, and exact
CREATE [UNIQUE] INDEXprefix. It adds regression coverage for:WithNoConcurrentIndexOps().Testing
GOTOOLCHAIN=go1.25.5 go test -race ./... -timeout 30mgolangci-lint v2.7.0 rungo vet ./...sqlfluff 3.3.0 lintgofmt,go mod tidy -diff, andgit diff --checkThe commit is GitHub Verified.
Fixes #253