kettle-jem: curate rubocop-gradual binstub generation - #62
Merged
Merged
Conversation
`bin/rubocop-gradual` was only surviving in destination projects because it happened to be git-tracked and `tracked_binstub?` (added in 3496816) protects tracked non-curated binstubs from pruning. That's a preservation safety net, not a generation path: a project that never manually created the binstub in the first place got nothing from the template. rubocop-gradual is already a template-declared dependency in gemfiles/modular/style.gemfile.example, so any project using the style gemfile has it in its bundle. Add it to CURATED_BINSTUB_GEMS so `kettle-jem install`'s curated `bundle binstubs` step generates bin/rubocop-gradual itself, the same as it does for rake, rbs, rspec-core, and yard. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SkhdTh8WyqNdRkUZ1aAgVi
pboling
force-pushed
the
kj/curate-rubocop-gradual-binstub
branch
from
September 9, 2026 00:01
f2fe1ce to
c3bfa9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bin/rubocop-gradualwas only surviving in destination projects because it happened to be git-tracked andtracked_binstub?(added in 3496816, "Preserve tracked Bundler binstubs") protects tracked non-curated binstubs from pruning. That's a preservation safety net, not a generation path — a project that never manually created the binstub in the first place got nothing from the template.rubocop-gradualis already a template-declared dependency ingemfiles/modular/style.gemfile.example, so any project using the style gemfile has it in its bundle already.rubocop-gradualtoCURATED_BINSTUB_GEMSinkettle-jemsokettle-jem install's curatedbundle binstubsstep generatesbin/rubocop-gradualitself, the same as it already does forrake,rbs,rspec-core, andyard.Context
Follow-up to fixing
rubocop-lts-rspec'sDogfoodCI workflow, wherebin/rubocop-gradual+ a frozenrubocop_gradual:dogfoodRake task had been wiped by an older kettle-jem version's binstub pruning. That specific repo is fixed already (git-tracked binstub +tracked_binstub?now protects it); this closes the actual gap so the binstub is generated by the template for any project going forward, not just preserved when someone hand-wrote it.Testing
bundle exec rspec spec/system/install_orchestration_spec.rb spec/integration/structural_merge_template_spec.rb— 120 examples, 0 failures.🤖 Generated with Claude Code