Skip to content

🔧 Run engine CI on automated release-validation PRs - #63

Merged
pboling merged 1 commit into
mainfrom
engines/fix-release-pr-ci-gate
Sep 13, 2026
Merged

pboling merged 1 commit into
mainfrom
engines/fix-release-pr-ci-gate

Conversation

@pboling

@pboling pboling commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

kettle-release opens a "release validation PR" before merging a release
branch into main, titled Release <branch-name> — reusing whatever
branch happened to be checked out rather than a conventionally-prefixed
one. The JRuby/TruffleRuby job if: conditions in the kettle-jem
templates only ran on PRs whose branch started with engines/,
jruby//truffleruby/, or feature/release, so a validation PR on an
arbitrarily-named branch silently skipped engine CI instead of
validating the release (observed live on galtzo-floss/turbo_tests2#50).

Adds startsWith(github.event.pull_request.title, 'Release ') as an
additional match alongside the existing branch-prefix checks, so engine
CI runs for these release-validation PRs regardless of the branch name
kettle-release reuses. Applied to all 15 .github/workflows/*.yml.example
templates under gems/kettle-jem that share this condition.

Discovered and already worked around downstream in galtzo-floss/turbo_tests2#50
and scripted across ~30 galtzo-floss family repos while the family's release
tooling was reconciling from an actual stuck release; this PR lands the fix
at the template source so future retemplating picks it up.

🤖 Generated with Claude Code

https://claude.ai/code/session_01URwq1vEg3L7F3ddUr5eEn4

kettle-release opens a "release validation PR" before merging a release
branch into main, titled "Release <branch-name>" — reusing whatever
branch happened to be checked out rather than a conventionally-prefixed
one. The JRuby/TruffleRuby job `if:` conditions only ran on PRs whose
branch started with `engines/`, `jruby/`/`truffleruby/`, or
`feature/release`, so a validation PR on an arbitrarily-named branch
silently skips engine CI instead of validating the release.

Add `startsWith(github.event.pull_request.title, 'Release ')` as an
additional match alongside the existing branch-prefix checks, so engine
CI runs for these release-validation PRs regardless of the branch name
kettle-release reuses. Applied identically to every job in this repo
that shares the condition.

Same fix as galtzo-floss/turbo_tests2#50, scripted across the family
instead of waiting for a full kettle-jem retemplate; also needs landing
in the kettle-jem template itself.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01URwq1vEg3L7F3ddUr5eEn4
@pboling
pboling merged commit 12f2c7d into main Sep 13, 2026
7 checks passed
@pboling
pboling deleted the engines/fix-release-pr-ci-gate branch September 13, 2026 03:10
This was referenced Sep 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant