馃悰 kettle-jem: stop overriding the github git source with SSH in the Gemfile template - #65
Merged
Merged
Conversation
The packaged Gemfile.example defined
git_source(:github) { |repo_name| "git@github.com:#{repo_name}.git" },
so every templated project locked its github: gems with git@github.com
remotes. CI runners have no SSH key, and locked_deps workflows failed in
rv clean-install ("Permission denied (publickey)"), blocking releases of
kettle-rb, kettle-ndjson, kettle-gha-pins and kettle-wash. Use Bundler's
built-in HTTPS github source instead, and invert the spec that asserted
the SSH override.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01P8aveNcdgPobyMrq8DkD9r
This was referenced Sep 14, 2026
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
gems/kettle-jem/lib/kettle/jem/templates/Gemfile.example(added in a61dca1) definesEvery templated project therefore locks its
github:gems withgit@github.com:remotes inGemfile.lock. CI runners have no SSH key, solocked_deps.ymlfails inrv clean-installwithPermission denied (publickey). This blocked the releases of kettle-rb, kettle-ndjson, kettle-gha-pins and kettle-wash (fixed per-repo in kettle-dev/kettle-rb#7, kettle-dev/kettle-ndjson#3, kettle-dev/kettle-gha-pins#2, kettle-dev/kettle-wash#2).Fix
github:source is used. Local SSH preferences still apply at clone time through git'surl.<base>.insteadOf, without being recorded in lockfiles.git_source(:github).Verified locally with
KETTLE_DEV_DEV=true(monorepo path gems):spec/integration/structural_merge_template_spec.rb, including the inverted example.Note: the Gemfile merge has no removal rule for
git_source, so projects already templated keep theirgit_source(:github)line until it is removed (and the lockfile relocked) in each project.Pre-existing, unrelated failure (also fails on origin/main with KETTLE_DEV_DEV=true):
馃 Generated with Claude Code
https://claude.ai/code/session_01P8aveNcdgPobyMrq8DkD9r