Repository navigation
ci: drop the unused expo setup, move to node 22 and publish with the built-in token - #33
Merged
Merged
Conversation
…built-in token The setup action installed eas-cli@latest, which now needs Node 22, so every PR check failed before running a single step. Nothing in CI uses EAS or Expo, so the step is gone, and CI runs on Node 22 since Node 20 is end-of-life. auto shipit authenticated to GitHub with the GH_TOKEN personal access token, which has expired. npm already publishes through trusted publishing, and the workflow's own token has the permissions auto needs, so no stored token is left. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CI fails on every branch since the last green run in January, for two reasons that have nothing to do with the code.
PR checks die in setup. The shared setup action ran
expo/expo-github-actionwitheas-version: lateston Node 20.latestis noweas-cli@24.12.1, whose@oclif/plugin-autocomplete@3.3.0requires Node 22 or newer, soyarn add eas-cliaborts before lint, Prettier, TypeScript or Jest run.EXPO_TOKENinput the action declared as required. The step and the input are gone.Testjob. Node 20 has been end-of-life since April.Publishstays on Node 24, which trusted publishing needs.Publish fails with
401 Bad credentials. npm already publishes through trusted publishing (#28), butauto shipitalso needs a GitHub token for the release, tag and PR comments. It used theGH_TOKENpersonal access token, which has expired.GITHUB_TOKEN. The job already grants the permissionsautoneeds (contents,pull-requestsanddeployments).SSH_KEYdeploy key from checkout, so that key must keep its push access tomain.After merging, the
GH_TOKENsecret can be deleted.Testing: this branch's own runs. The PR check should go green, and the push to this branch runs
Publish, which publishes a canary through the new token, the same as every branch push today.Related Tickets/Issues
Unblocks #32.
🤖 Generated with Claude Code
📦 Published PR as canary version:
0.1.14--canary.33.da32331.0✨ Test out this PR locally via:
npm install @strv/react-native-hero-carousel@0.1.14--canary.33.da32331.0 # or yarn add @strv/react-native-hero-carousel@0.1.14--canary.33.da32331.0