Repository navigation
Fix Release for changesets/action v2; test sign-in routes and the secrets file - #14
Merged
Merged
Conversation
…nd the secrets file changesets/action v2 renamed its inputs (version-script, publish-script, commit-message, pr-title) and fails on the old names, so Release has failed on main since the bump. The cloud routes the viewer serves and credentials-file.ts had no direct tests: sign-in refusals, sign-out keeping the model connection, an escaped cancelled callback, and the file's modes, atomic write and fallbacks. Signed-off-by: Michael Parker <michael@stuntdouble.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
changesets/action@v2renamed its inputs and errors on the old ones, so Release has failed on every push tomainsince the bump. Renamedversion,publish,commit,titletoversion-script,publish-script,commit-message,pr-title.test/credentials-file.test.ts(new): 0700 folder and 0600 file, no temp file left behind, missing/corrupt/wrongly shaped file reads as empty, updates keep unknown keys, forget is idempotent.test/viewer.test.ts: the cloud routes the viewer serves. Signed out, workspace listing is refused in words; choosing a workspace needs an id; sign-in needs this page's Origin; sign-out drops the sign-in, keeps the model connection and never sends the token to the page; a cancelled OAuth callback is escaped and does not redirect.No changeset: tests and CI only.
Checks
pnpm format:check,pnpm lint,pnpm type-check,pnpm test(129 pass, 0 skipped) andpnpm buildpass locally.